Skip to content

Commit 82d3239

Browse files
committed
remove match from tests
1 parent 29e9045 commit 82d3239

File tree

1 file changed

+20
-50
lines changed

1 file changed

+20
-50
lines changed

tests/integrations/rust_tracing/test_rust_tracing.py

Lines changed: 20 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,20 @@
1010
from sentry_sdk import start_transaction, capture_message
1111

1212

13+
def _test_event_type_mapping(metadata: dict[str, object]) -> EventTypeMapping:
14+
level = RustTracingLevel(metadata.get("level"))
15+
if level == RustTracingLevel.Error:
16+
return EventTypeMapping.Exc
17+
elif level in (RustTracingLevel.Warn, RustTracingLevel.Info):
18+
return EventTypeMapping.Breadcrumb
19+
elif level == RustTracingLevel.Debug:
20+
return EventTypeMapping.Event
21+
elif level == RustTracingLevel.Trace:
22+
return EventTypeMapping.Ignore
23+
else:
24+
return EventTypeMapping.Ignore
25+
26+
1327
class FakeRustTracing:
1428
# Parameters: `level`, `index`
1529
span_template = Template(
@@ -162,20 +176,9 @@ def test_on_new_span_without_transaction(sentry_init, reset_integrations):
162176

163177

164178
def test_on_event_exception(sentry_init, reset_integrations, capture_events):
165-
def event_type_mapping(metadata: dict) -> EventTypeMapping:
166-
match RustTracingLevel(metadata.get("level")):
167-
case RustTracingLevel.Error:
168-
return EventTypeMapping.Exc
169-
case RustTracingLevel.Warn | RustTracingLevel.Info:
170-
return EventTypeMapping.Breadcrumb
171-
case RustTracingLevel.Debug:
172-
return EventTypeMapping.Event
173-
case RustTracingLevel.Trace:
174-
return EventTypeMapping.Ignore
175-
176179
rust_tracing = FakeRustTracing()
177180
integration = RustTracingIntegration(
178-
"test", rust_tracing.set_layer_impl, event_type_mapping=event_type_mapping
181+
"test", rust_tracing.set_layer_impl, event_type_mapping=_test_event_type_mapping
179182
)
180183
sentry_init(integrations=[integration], traces_sample_rate=1.0)
181184

@@ -207,20 +210,9 @@ def event_type_mapping(metadata: dict) -> EventTypeMapping:
207210

208211

209212
def test_on_event_breadcrumb(sentry_init, reset_integrations, capture_events):
210-
def event_type_mapping(metadata: dict) -> EventTypeMapping:
211-
match RustTracingLevel(metadata.get("level")):
212-
case RustTracingLevel.Error:
213-
return EventTypeMapping.Exc
214-
case RustTracingLevel.Warn | RustTracingLevel.Info:
215-
return EventTypeMapping.Breadcrumb
216-
case RustTracingLevel.Debug:
217-
return EventTypeMapping.Event
218-
case RustTracingLevel.Trace:
219-
return EventTypeMapping.Ignore
220-
221213
rust_tracing = FakeRustTracing()
222214
integration = RustTracingIntegration(
223-
"test", rust_tracing.set_layer_impl, event_type_mapping=event_type_mapping
215+
"test", rust_tracing.set_layer_impl, event_type_mapping=_test_event_type_mapping
224216
)
225217
sentry_init(integrations=[integration], traces_sample_rate=1.0)
226218

@@ -247,20 +239,9 @@ def event_type_mapping(metadata: dict) -> EventTypeMapping:
247239

248240

249241
def test_on_event_event(sentry_init, reset_integrations, capture_events):
250-
def event_type_mapping(metadata: dict) -> EventTypeMapping:
251-
match RustTracingLevel(metadata.get("level")):
252-
case RustTracingLevel.Error:
253-
return EventTypeMapping.Exc
254-
case RustTracingLevel.Warn | RustTracingLevel.Info:
255-
return EventTypeMapping.Breadcrumb
256-
case RustTracingLevel.Debug:
257-
return EventTypeMapping.Event
258-
case RustTracingLevel.Trace:
259-
return EventTypeMapping.Ignore
260-
261242
rust_tracing = FakeRustTracing()
262243
integration = RustTracingIntegration(
263-
"test", rust_tracing.set_layer_impl, event_type_mapping=event_type_mapping
244+
"test", rust_tracing.set_layer_impl, event_type_mapping=_test_event_type_mapping
264245
)
265246
sentry_init(integrations=[integration], traces_sample_rate=1.0)
266247

@@ -293,20 +274,9 @@ def event_type_mapping(metadata: dict) -> EventTypeMapping:
293274

294275

295276
def test_on_event_ignored(sentry_init, reset_integrations, capture_events):
296-
def event_type_mapping(metadata: dict) -> EventTypeMapping:
297-
match RustTracingLevel(metadata.get("level")):
298-
case RustTracingLevel.Error:
299-
return EventTypeMapping.Exc
300-
case RustTracingLevel.Warn | RustTracingLevel.Info:
301-
return EventTypeMapping.Breadcrumb
302-
case RustTracingLevel.Debug:
303-
return EventTypeMapping.Event
304-
case RustTracingLevel.Trace:
305-
return EventTypeMapping.Ignore
306-
307277
rust_tracing = FakeRustTracing()
308278
integration = RustTracingIntegration(
309-
"test", rust_tracing.set_layer_impl, event_type_mapping=event_type_mapping
279+
"test", rust_tracing.set_layer_impl, event_type_mapping=_test_event_type_mapping
310280
)
311281
sentry_init(integrations=[integration], traces_sample_rate=1.0)
312282

@@ -328,7 +298,7 @@ def event_type_mapping(metadata: dict) -> EventTypeMapping:
328298

329299

330300
def test_span_filter(sentry_init, reset_integrations, capture_events):
331-
def span_filter(metadata: dict) -> bool:
301+
def span_filter(metadata: dict[str, object]) -> bool:
332302
return RustTracingLevel(metadata.get("level")) in (
333303
RustTracingLevel.Error,
334304
RustTracingLevel.Warn,
@@ -385,7 +355,7 @@ def test_record(sentry_init, reset_integrations):
385355

386356

387357
def test_record_in_ignored_span(sentry_init, reset_integrations):
388-
def span_filter(metadata: dict) -> bool:
358+
def span_filter(metadata: dict[str, object]) -> bool:
389359
# Just ignore Trace
390360
return RustTracingLevel(metadata.get("level")) != RustTracingLevel.Trace
391361

0 commit comments

Comments
 (0)