Skip to content

Commit 8845c72

Browse files
committed
Skip brotli on 3.6
1 parent 4332feb commit 8845c72

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

sentry_sdk/_compat.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010

1111

1212
PY37 = sys.version_info[0] == 3 and sys.version_info[1] >= 7
13+
PY38 = sys.version_info[0] == 3 and sys.version_info[1] >= 8
1314
PY310 = sys.version_info[0] == 3 and sys.version_info[1] >= 10
1415
PY311 = sys.version_info[0] == 3 and sys.version_info[1] >= 11
1516

tests/test_transport.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
get_isolation_scope,
2424
Hub,
2525
)
26+
from sentry_sdk._compat import PY37, PY38
2627
from sentry_sdk.envelope import Envelope, Item, parse_json
2728
from sentry_sdk.transport import (
2829
KEEP_ALIVE_SOCKET_OPTIONS,
@@ -123,10 +124,11 @@ def mock_transaction_envelope(span_count):
123124
@pytest.mark.parametrize("client_flush_method", ["close", "flush"])
124125
@pytest.mark.parametrize("use_pickle", (True, False))
125126
@pytest.mark.parametrize("compression_level", (0, 9, None))
126-
@pytest.mark.parametrize("compression_algo", ("gzip", "br", "<invalid>", None))
127127
@pytest.mark.parametrize(
128-
"http2", [True, False] if sys.version_info >= (3, 8) else [False]
128+
"compression_algo",
129+
("gzip", "br", "<invalid>", None) if PY37 else ("gzip", "<invalid>", None),
129130
)
131+
@pytest.mark.parametrize("http2", [True, False] if PY38 else [False])
130132
def test_transport_works(
131133
capturing_server,
132134
request,

0 commit comments

Comments
 (0)