Skip to content

Commit 88c84f4

Browse files
update tests
1 parent 84ef52a commit 88c84f4

File tree

1 file changed

+15
-39
lines changed

1 file changed

+15
-39
lines changed

tests/tracing/test_ignore_status_codes.py

Lines changed: 15 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,9 @@ def test_no_ignored_codes(sentry_init, capture_events):
2121
def test_single_code_ignored(sentry_init, capture_events, status_code):
2222
sentry_init(
2323
traces_sample_rate=1.0,
24-
trace_ignore_status_codes=(404,),
24+
trace_ignore_status_codes={
25+
404,
26+
},
2527
)
2628
events = capture_events()
2729

@@ -39,10 +41,10 @@ def test_single_code_ignored(sentry_init, capture_events, status_code):
3941
def test_range_ignored(sentry_init, capture_events, status_code):
4042
sentry_init(
4143
traces_sample_rate=1.0,
42-
trace_ignore_status_codes=(
43-
(
44+
trace_ignore_status_codes=set(
45+
range(
4446
305,
45-
399,
47+
400,
4648
),
4749
),
4850
)
@@ -62,19 +64,19 @@ def test_range_ignored(sentry_init, capture_events, status_code):
6264
def test_variety_ignored(sentry_init, capture_events, status_code):
6365
sentry_init(
6466
traces_sample_rate=1.0,
65-
trace_ignore_status_codes=(
67+
trace_ignore_status_codes={
6668
301,
6769
302,
6870
303,
69-
(
71+
*range(
7072
305,
71-
399,
73+
400,
7274
),
73-
(
75+
*range(
7476
401,
75-
404,
77+
405,
7678
),
77-
),
79+
},
7880
)
7981
events = capture_events()
8082

@@ -92,40 +94,14 @@ def test_variety_ignored(sentry_init, capture_events, status_code):
9294
assert len(events) == 1
9395

9496

95-
def test_malformed_argument_ignored(sentry_init, capture_events):
96-
sentry_init(
97-
traces_sample_rate=1.0,
98-
trace_ignore_status_codes=(
99-
404.0,
100-
"404",
101-
"401-404",
102-
(404,),
103-
(
104-
"401",
105-
"404",
106-
),
107-
(
108-
401,
109-
404,
110-
500,
111-
),
112-
),
113-
)
114-
events = capture_events()
115-
116-
with start_transaction(op="http", name="GET /"):
117-
span_or_tx = sentry_sdk.get_current_span()
118-
span_or_tx.set_data("http.response.status_code", 404)
119-
120-
assert len(events) == 1
121-
122-
12397
def test_transaction_not_ignored_when_status_code_has_invalid_type(
12498
sentry_init, capture_events
12599
):
126100
sentry_init(
127101
traces_sample_rate=1.0,
128-
trace_ignore_status_codes=((401, 404),),
102+
trace_ignore_status_codes=set(
103+
range(401, 404),
104+
),
129105
)
130106
events = capture_events()
131107

0 commit comments

Comments
 (0)