Skip to content

Commit 8e5924d

Browse files
authored
fix: Rename meta key to _meta (#133)
* fix: Rename meta key to _meta Fix #131 * fix: Fix test
1 parent c931be5 commit 8e5924d

File tree

4 files changed

+11
-8
lines changed

4 files changed

+11
-8
lines changed

sentry_sdk/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -552,7 +552,7 @@ def inner(obj):
552552

553553
obj, meta = inner(obj)
554554
if meta is not None:
555-
obj[""] = meta
555+
obj["_meta"] = meta
556556
return obj
557557

558558

tests/integrations/django/test_basic.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,10 @@ def test_request_body(sentry_init, client, capture_events):
200200

201201
assert event["message"] == "hi"
202202
assert event["request"]["data"] == ""
203-
assert event[""]["request"]["data"][""] == {"len": 6, "rem": [["!raw", "x", 0, 6]]}
203+
assert event["_meta"]["request"]["data"][""] == {
204+
"len": 6,
205+
"rem": [["!raw", "x", 0, 6]],
206+
}
204207

205208
del events[:]
206209

tests/integrations/flask/test_flask.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ def index():
203203
assert response.status_code == 200
204204

205205
event, = events
206-
assert event[""]["request"]["data"]["foo"]["bar"] == {
206+
assert event["_meta"]["request"]["data"]["foo"]["bar"] == {
207207
"": {"len": 2000, "rem": [["!limit", "x", 509, 512]]}
208208
}
209209
assert len(event["request"]["data"]["foo"]["bar"]) == 512
@@ -229,7 +229,7 @@ def index():
229229
assert response.status_code == 200
230230

231231
event, = events
232-
assert event[""]["request"]["data"]["foo"] == {
232+
assert event["_meta"]["request"]["data"]["foo"] == {
233233
"": {"len": 2000, "rem": [["!limit", "x", 509, 512]]}
234234
}
235235
assert len(event["request"]["data"]["foo"]) == 512
@@ -259,7 +259,7 @@ def index():
259259
assert response.status_code == 200
260260

261261
event, = events
262-
assert event[""]["request"]["data"] == {
262+
assert event["_meta"]["request"]["data"] == {
263263
"": {"len": 2000, "rem": [["!config", "x", 0, 2000]]}
264264
}
265265
assert not event["request"]["data"]
@@ -285,12 +285,12 @@ def index():
285285
assert response.status_code == 200
286286

287287
event, = events
288-
assert event[""]["request"]["data"]["foo"] == {
288+
assert event["_meta"]["request"]["data"]["foo"] == {
289289
"": {"len": 2000, "rem": [["!limit", "x", 509, 512]]}
290290
}
291291
assert len(event["request"]["data"]["foo"]) == 512
292292

293-
assert event[""]["request"]["data"]["file"] == {
293+
assert event["_meta"]["request"]["data"]["file"] == {
294294
"": {"len": 0, "rem": [["!raw", "x", 0, 0]]}
295295
}
296296
assert not event["request"]["data"]["file"]

tests/test_event.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ def test_flatten_metadata():
66
assert flatten_metadata({"foo": ["bar"]}) == {"foo": [u"bar"]}
77
assert flatten_metadata({"foo": [AnnotatedValue("bar", u"meta")]}) == {
88
"foo": [u"bar"],
9-
"": {"foo": {"0": {"": u"meta"}}},
9+
"_meta": {"foo": {"0": {"": u"meta"}}},
1010
}
1111

1212

0 commit comments

Comments
 (0)