Updated some tests to use old default

Author: antonpirker

tests/opentelemetry/test_sampler.py

@@ -178,8 +178,8 @@ def keep_only_a(sampling_context):
 @pytest.mark.parametrize(
     "traces_sample_rate, expected_num_of_envelopes",
     [
-        # special case for testing, do not pass any traces_sample_rate to init() (the default traces_sample_rate=0 will be used)
-        (USE_DEFAULT_TRACES_SAMPLE_RATE, 1),
+        # special case for testing, do not pass any traces_sample_rate to init() (the default traces_sample_rate=None will be used)
+        (USE_DEFAULT_TRACES_SAMPLE_RATE, 0),
         # traces_sample_rate=None means do not create new traces, and also do not continue incoming traces. So, no envelopes at all.
         (None, 0),
         # traces_sample_rate=0 means do not create new traces (0% of the requests), but continue incoming traces. So envelopes will be created only if there is an incoming trace.
@@ -229,9 +229,9 @@ def test_sampling_parent_sampled(
 @pytest.mark.parametrize(
     "traces_sample_rate, upstream_sampled, expected_num_of_envelopes",
     [
-        # special case for testing, do not pass any traces_sample_rate to init() (the default traces_sample_rate=0 will be used)
+        # special case for testing, do not pass any traces_sample_rate to init() (the default traces_sample_rate=None will be used)
         (USE_DEFAULT_TRACES_SAMPLE_RATE, 0, 0),
-        (USE_DEFAULT_TRACES_SAMPLE_RATE, 1, 1),
+        (USE_DEFAULT_TRACES_SAMPLE_RATE, 1, 0),
         # traces_sample_rate=None means do not create new traces, and also do not continue incoming traces. So, no envelopes at all.
         (None, 0, 0),
         (None, 1, 0),

tests/test_dsc.py

@@ -287,8 +287,8 @@ def my_traces_sampler(sampling_context):
                 "local_traces_sampler_result": None,
                 "local_traces_sample_rate": None,
             },
-            1.0,  # expected_sample_rate
-            "true",  # expected_sampled
+            None,  # expected_sample_rate
+            "tracing-disabled-no-transactions-should-be-sent",  # expected_sampled (traces_sample_rate=None disables all transaction creation)
         ),
         (  # 6 traces_sampler overrides incoming  (traces_sample_rate not set)
             {