Merge remote-tracking branch 'origin/master' into wsgi-middleware

Author: untitaker

tests/integrations/django/myapp/management/__init__.py

@@ -0,0 +1,9 @@
+from django.core.management.base import BaseCommand
+
+
+class Command(BaseCommand):
+    def add_arguments(self, parser):
+        pass
+
+    def handle(self, *args, **options):
+        1 / 0

tests/integrations/django/myapp/management/commands/__init__.py

@@ -48,6 +48,7 @@
     "django.contrib.sessions",
     "django.contrib.messages",
     "django.contrib.staticfiles",
+    "tests.integrations.django.myapp",
 ]
 
 

tests/integrations/django/myapp/management/commands/mycrash.py

@@ -3,8 +3,9 @@
 django = pytest.importorskip("django")
 
 
-from tests.integrations.django.myapp.wsgi import application
 from werkzeug.test import Client
+from django.core.management import execute_from_command_line
+
 
 try:
     from django.urls import reverse
@@ -13,6 +14,8 @@
 
 from sentry_sdk import Hub
 
+from tests.integrations.django.myapp.wsgi import application
+
 
 @pytest.fixture
 def client(monkeypatch_test_transport):
@@ -72,3 +75,11 @@ def test_user_captured(client, capture_events):
 def test_404(client):
     content, status, headers = client.get("/404")
     assert status.lower() == "404 not found"
+
+
+def test_management_command_raises():
+    # This just checks for our assumption that Django passes through all
+    # exceptions by default, so our excepthook can be used for management
+    # commands.
+    with pytest.raises(ZeroDivisionError):
+        execute_from_command_line(["manage.py", "mycrash"])

tests/integrations/django/myapp/settings.py

@@ -324,3 +324,19 @@ def index():
 def test_no_errors_without_request(app):
     with app.app_context():
         capture_exception(ValueError())
+
+
+def test_cli_commands_raise(app):
+    if not hasattr(app, "cli"):
+        pytest.skip("Too old flask version")
+
+    from flask.cli import ScriptInfo
+
+    @app.cli.command()
+    def foo():
+        1 / 0
+
+    with pytest.raises(ZeroDivisionError):
+        app.cli.main(
+            args=["foo"], prog_name="myapp", obj=ScriptInfo(create_app=lambda _: app)
+        )