Do not change the default value of traces_sample_rate

Author: antonpirker

sentry_sdk/consts.py

@@ -551,7 +551,7 @@ def __init__(
         debug=None,  # type: Optional[bool]
         attach_stacktrace=False,  # type: bool
         ca_certs=None,  # type: Optional[str]
-        traces_sample_rate=0,  # type: Optional[float]
+        traces_sample_rate=None,  # type: Optional[float]
         traces_sampler=None,  # type: Optional[TracesSampler]
         profiles_sample_rate=None,  # type: Optional[float]
         profiles_sampler=None,  # type: Optional[TracesSampler]

tests/tracing/test_trace_propagation.py

@@ -190,7 +190,11 @@ def test_with_incoming_trace_and_trace_propagation_targets_matching(
             requests.get("http://example.com")
 
     # CHECK if performance data (a transaction/span) is sent to Sentry
-    if traces_sample_rate is None or incoming_parent_sampled == "0":
+    if (
+        traces_sample_rate is None
+        or traces_sample_rate == USE_DEFAULT_TRACES_SAMPLE_RATE
+        or incoming_parent_sampled == "0"
+    ):
         assert len(events) == 0
     else:
         if incoming_parent_sampled == "1" or traces_sample_rate == 1:
@@ -264,7 +268,11 @@ def test_with_incoming_trace_and_trace_propagation_targets_not_matching(
             requests.get("http://example.com")
 
     # CHECK if performance data (a transaction/span) is sent to Sentry
-    if traces_sample_rate is None or incoming_parent_sampled == "0":
+    if (
+        traces_sample_rate is None
+        or traces_sample_rate == USE_DEFAULT_TRACES_SAMPLE_RATE
+        or incoming_parent_sampled == "0"
+    ):
         assert len(events) == 0
     else:
         if incoming_parent_sampled == "1" or traces_sample_rate == 1: