fix(spans): fixing mypy errors

Author: constantinius

sentry_sdk/_types.py

@@ -22,6 +22,8 @@
     from typing import Union
     from typing_extensions import Literal, TypedDict
 
+    from sentry_sdk.utils import Annotated
+
     class SDKInfo(TypedDict):
         name: str
         version: str
@@ -101,7 +103,7 @@ class SDKInfo(TypedDict):
             "request": dict[str, object],
             "sdk": Mapping[str, object],
             "server_name": str,
-            "spans": list[dict[str, object]],
+            "spans": Annotated[list[dict[str, object]]],
             "stacktrace": dict[
                 str, object
             ],  # We access this key in the code, but I am unsure whether we ever set it

sentry_sdk/client.py

@@ -491,7 +491,7 @@ def _prepare_event(
 
         if scope is not None:
             is_transaction = event.get("type") == "transaction"
-            spans_before = len(event.get("spans", []))
+            spans_before = len(cast(list[dict[str, object]], event.get("spans", [])))
             event_ = scope.apply_to_event(event, hint, self.options)
 
             # one of the event/error processors returned None
@@ -510,7 +510,7 @@ def _prepare_event(
                 return None
 
             event = event_
-            spans_delta = spans_before - len(event.get("spans", []))
+            spans_delta = spans_before - len(cast(list[dict[str, object]], event.get("spans", [])))
             if is_transaction and spans_delta > 0 and self.transport is not None:
                 self.transport.record_lost_event(
                     "event_processor", data_category="span", quantity=spans_delta
@@ -609,7 +609,7 @@ def _prepare_event(
             and event.get("type") == "transaction"
         ):
             new_event = None
-            spans_before = len(event.get("spans", []))
+            spans_before = len(cast(list[dict[str, object]], event.get("spans", [])))
             with capture_internal_exceptions():
                 new_event = before_send_transaction(event, hint or {})
             if new_event is None:

sentry_sdk/scrubber.py

@@ -4,7 +4,7 @@
     iter_event_frames,
 )
 
-from typing import TYPE_CHECKING
+from typing import TYPE_CHECKING, cast
 
 if TYPE_CHECKING:
     from sentry_sdk._types import Event
@@ -161,7 +161,7 @@ def scrub_spans(self, event):
         # type: (Event) -> None
         with capture_internal_exceptions():
             if "spans" in event:
-                for span in event["spans"]:
+                for span in cast(list[dict[str, object]], event["spans"]):
                     if "data" in span:
                         self.scrub_dict(span["data"])
 

sentry_sdk/transport.py

@@ -24,7 +24,7 @@
 from sentry_sdk.worker import BackgroundWorker
 from sentry_sdk.envelope import Envelope, Item, PayloadRef
 
-from typing import TYPE_CHECKING
+from typing import TYPE_CHECKING, cast
 
 if TYPE_CHECKING:
     from typing import Any
@@ -280,7 +280,7 @@ def record_lost_event(
                 event = item.get_transaction_event() or {}
 
                 # +1 for the transaction itself
-                span_count = len(event.get("spans") or []) + 1
+                span_count = len(cast(list[dict[str, object]], event.get("spans") or [])) + 1
                 self.record_lost_event(reason, "span", quantity=span_count)
 
             elif data_category == "attachment":