Skip to content

Commit 95e54bf

Browse files
committed
make sure tests assert correctly
1 parent d295ee0 commit 95e54bf

File tree

1 file changed

+12
-6
lines changed

1 file changed

+12
-6
lines changed

tests/integrations/langchain/test_langchain.py

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import json
12
from typing import List, Optional, Any, Iterator
23
from unittest import mock
34
from unittest.mock import Mock, patch
@@ -884,8 +885,6 @@ def test_langchain_message_role_mapping(sentry_init, capture_events):
884885

885886
# Parse the message data (might be JSON string)
886887
if isinstance(messages_data, str):
887-
import json
888-
889888
try:
890889
messages = json.loads(messages_data)
891890
except json.JSONDecodeError:
@@ -979,7 +978,13 @@ def test_langchain_message_truncation(sentry_init, capture_events):
979978
large_content = (
980979
"This is a very long message that will exceed our size limits. " * 1000
981980
)
982-
prompts = [large_content, large_content, large_content, large_content]
981+
prompts = [
982+
"small message 1",
983+
large_content,
984+
large_content,
985+
"small message 4",
986+
"small message 5",
987+
]
983988

984989
with start_transaction():
985990
callback.on_llm_start(
@@ -1020,8 +1025,9 @@ def test_langchain_message_truncation(sentry_init, capture_events):
10201025
messages_data = llm_span["data"][SPANDATA.GEN_AI_REQUEST_MESSAGES]
10211026
assert isinstance(messages_data, str)
10221027

1023-
import json
1024-
10251028
parsed_messages = json.loads(messages_data)
10261029
assert isinstance(parsed_messages, list)
1027-
assert len(parsed_messages) <= len(prompts)
1030+
assert len(parsed_messages) == 2
1031+
assert "small message 4" in str(parsed_messages[0])
1032+
assert "small message 5" in str(parsed_messages[1])
1033+
assert tx["_meta"]["spans"]["0"]["data"]["gen_ai.request.messages"][""]["len"] == 5

0 commit comments

Comments
 (0)