Skip to content

Commit 98422f9

Browse files
committed
test(loguru): Use regex pattern instead of inspection
Replaced the inspection logic for the line number with a simple regex pattern that checks for the presence of an integer.
1 parent b1340fb commit 98422f9

File tree

1 file changed

+9
-12
lines changed

1 file changed

+9
-12
lines changed

tests/integrations/loguru/test_loguru.py

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
from unittest.mock import MagicMock, patch
2-
import inspect
2+
import re
33

44
import pytest
55
from loguru import logger
@@ -55,17 +55,12 @@ def test_just_log(
5555
)
5656
events = capture_events()
5757

58-
frame = inspect.currentframe()
59-
assert frame is not None
60-
log_line_number = frame.f_lineno + 1
6158
getattr(logger, level.name.lower())("test")
6259

63-
formatted_message = (
64-
" | "
65-
+ "{:9}".format(level.name.upper())
66-
+ "| tests.integrations.loguru.test_loguru:test_just_log:{} - test".format(
67-
log_line_number
68-
)
60+
expected_pattern = (
61+
r" \| "
62+
+ r"{:9}".format(level.name.upper())
63+
+ r"\| tests\.integrations\.loguru\.test_loguru:test_just_log:\d+ - test"
6964
)
7065

7166
if not created_event:
@@ -78,7 +73,8 @@ def test_just_log(
7873
(breadcrumb,) = breadcrumbs
7974
assert breadcrumb["level"] == expected_sentry_level
8075
assert breadcrumb["category"] == "tests.integrations.loguru.test_loguru"
81-
assert breadcrumb["message"][23:] == formatted_message
76+
# Check that the message matches the expected pattern with a line number
77+
assert re.search(expected_pattern, breadcrumb["message"][23:])
8278
else:
8379
assert not breadcrumbs
8480

@@ -91,7 +87,8 @@ def test_just_log(
9187
(event,) = events
9288
assert event["level"] == expected_sentry_level
9389
assert event["logger"] == "tests.integrations.loguru.test_loguru"
94-
assert event["logentry"]["message"][23:] == formatted_message
90+
# Check that the message matches the expected pattern with a line number
91+
assert re.search(expected_pattern, event["logentry"]["message"][23:])
9592

9693

9794
def test_breadcrumb_format(sentry_init, capture_events, uninstall_integration, request):

0 commit comments

Comments
 (0)