Move parametrization to conftest

Author: vrslev

tests/integrations/conftest.py

@@ -32,3 +32,24 @@ def capture_event_scope(self, event, hint=None, scope=None):
         return errors
 
     return inner
+
+
+parametrize_test_configurable_status_codes = pytest.mark.parametrize(
+    ("failed_request_status_codes", "status_code", "expected_error"),
+    (
+        (None, 500, True),
+        (None, 400, False),
+        ({500, 501}, 500, True),
+        ({500, 501}, 401, False),
+        ({*range(400, 500)}, 401, True),
+        ({*range(400, 500)}, 500, False),
+        ({*range(400, 600)}, 300, False),
+        ({*range(400, 600)}, 403, True),
+        ({*range(400, 600)}, 503, True),
+        ({*range(400, 403), 500, 501}, 401, True),
+        ({*range(400, 403), 500, 501}, 405, False),
+        ({*range(400, 403), 500, 501}, 501, True),
+        ({*range(400, 403), 500, 501}, 503, False),
+        (set(), 500, False),
+    ),
+)

tests/integrations/fastapi/test_fastapi.py

@@ -19,6 +19,7 @@
 
 FASTAPI_VERSION = parse_version(fastapi.__version__)
 
+from tests.integrations.conftest import parametrize_test_configurable_status_codes
 from tests.integrations.starlette import test_starlette
 
 
@@ -650,7 +651,7 @@ def test_transaction_http_method_custom(sentry_init, capture_events):
     assert event2["request"]["method"] == "HEAD"
 
 
-@test_starlette.parametrize_test_configurable_status_codes
+@parametrize_test_configurable_status_codes
 def test_configurable_status_codes(
     sentry_init,
     capture_events,

tests/integrations/litestar/test_litestar.py

@@ -17,7 +17,7 @@
 from litestar.middleware.session.server_side import ServerSideSessionConfig
 from litestar.testing import TestClient
 
-from tests.integrations.starlette import test_starlette
+from tests.integrations.conftest import parametrize_test_configurable_status_codes
 
 
 def litestar_app_factory(middleware=None, debug=True, exception_handlers=None):
@@ -399,7 +399,7 @@ async def __call__(self, scope, receive, send):
         }
     else:
         assert "user" not in event
-@test_starlette.parametrize_test_configurable_status_codes
+@parametrize_test_configurable_status_codes
 def test_configurable_status_codes(
     sentry_init,
     capture_events,

tests/integrations/starlette/test_starlette.py

@@ -32,6 +32,8 @@
 from starlette.middleware.trustedhost import TrustedHostMiddleware
 from starlette.testclient import TestClient
 
+from tests.integrations.conftest import parametrize_test_configurable_status_codes
+
 
 STARLETTE_VERSION = parse_version(starlette.__version__)
 
@@ -1298,27 +1300,6 @@ def test_transaction_http_method_custom(sentry_init, capture_events):
     assert event2["request"]["method"] == "HEAD"
 
 
-parametrize_test_configurable_status_codes = pytest.mark.parametrize(
-    ("failed_request_status_codes", "status_code", "expected_error"),
-    (
-        (None, 500, True),
-        (None, 400, False),
-        ({500, 501}, 500, True),
-        ({500, 501}, 401, False),
-        ({*range(400, 500)}, 401, True),
-        ({*range(400, 500)}, 500, False),
-        ({*range(400, 600)}, 300, False),
-        ({*range(400, 600)}, 403, True),
-        ({*range(400, 600)}, 503, True),
-        ({*range(400, 403), 500, 501}, 401, True),
-        ({*range(400, 403), 500, 501}, 405, False),
-        ({*range(400, 403), 500, 501}, 501, True),
-        ({*range(400, 403), 500, 501}, 503, False),
-        (set(), 500, False),
-    ),
-)
-
-
 @parametrize_test_configurable_status_codes
 def test_configurable_status_codes(
     sentry_init,