bugfix: request data for flask was not attached

Author: untitaker

sentry_sdk/integrations/flask.py

@@ -86,9 +86,9 @@ def _before_request(*args, **kwargs):
         get_current_hub().capture_internal_exception()
 
 def _get_request_info():
-    {
-        'url': '%s://%s%s' % (request.scheme, urlparts.host, request.path),
-        'query_string': urlparts.query,
+    return {
+        'url': '%s://%s%s' % (request.scheme, request.host, request.path),
+        'query_string': request.query_string,
         'method': request.method,
         'data': request.get_data(cache=True, as_text=True, parse_form_data=True),
         'headers': dict(request.headers),

tests/integrations/conftest.py

@@ -6,11 +6,6 @@ class TestClient(Client):
     def __init__(self):
         pass
 
-    def capture_internal_exception(self, error=None):
-        if not error:
-            raise
-        raise error
-
     dsn = 'LOL'
     options = {'with_locals': False, 'release': 'fake_release', 'environment': 'fake_environment', 'server_name': 'fake_servername'}
     _transport = None
@@ -31,6 +26,17 @@ def close(self):
 sentry_sdk.init()
 sentry_sdk.get_current_hub().bind_client(test_client)
 
+@pytest.fixture(autouse=True)
+def reraise_internal_exceptions(monkeypatch):
+    def capture_internal_exception(error=None):
+        if not error:
+            raise
+        raise error
+
+    monkeypatch.setattr(sentry_sdk.get_current_hub(),
+                        'capture_internal_exception',
+                        capture_internal_exception)
+
 
 @pytest.fixture
 def capture_exceptions(monkeypatch):

tests/integrations/flask/test_flask.py

@@ -35,6 +35,8 @@ def test_has_context(app):
     def index():
         with configure_scope() as scope:
             assert scope._data['transaction'] is 'index'
+            assert scope._data['request']['data'] == ''
+            assert scope._data['request']['url'] == 'http://localhost/'
 
         return 'ok'