Skip to content

Commit a29716b

Browse files
committed
Add common otel attributes
1 parent f2edb38 commit a29716b

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

sentry_sdk/integrations/openai.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,13 +124,11 @@ def _calculate_token_usage(
124124
total_tokens = _get_usage(response.usage, ["total_tokens"])
125125

126126
# Manually count tokens
127-
# TODO: when implementing responses API, check for responses API
128127
if input_tokens == 0:
129128
for message in messages:
130129
if "content" in message:
131130
input_tokens += count_tokens(message["content"])
132131

133-
# TODO: when implementing responses API, check for responses API
134132
if output_tokens == 0:
135133
if streaming_message_responses is not None:
136134
for message in streaming_message_responses:
@@ -191,7 +189,9 @@ def _new_chat_completion_common(f, *args, **kwargs):
191189
if should_send_default_pii() and integration.include_prompts:
192190
set_data_normalized(span, SPANDATA.GEN_AI_REQUEST_MESSAGES, messages)
193191

192+
set_data_normalized(span, SPANDATA.GEN_AI_SYSTEM, "openai")
194193
set_data_normalized(span, SPANDATA.GEN_AI_REQUEST_MODEL, model)
194+
set_data_normalized(span, SPANDATA.GEN_AI_OPERATION_NAME, "chat")
195195
set_data_normalized(span, SPANDATA.AI_STREAMING, streaming)
196196

197197
if hasattr(res, "choices"):
@@ -368,7 +368,9 @@ def _new_embeddings_create_common(f, *args, **kwargs):
368368
name=f"embeddings {model}",
369369
origin=OpenAIIntegration.origin,
370370
) as span:
371+
set_data_normalized(span, SPANDATA.GEN_AI_SYSTEM, "openai")
371372
set_data_normalized(span, SPANDATA.GEN_AI_REQUEST_MODEL, model)
373+
set_data_normalized(span, SPANDATA.GEN_AI_OPERATION_NAME, "embeddings")
372374

373375
if "input" in kwargs and (
374376
should_send_default_pii() and integration.include_prompts
@@ -496,7 +498,9 @@ def _new_responses_create_common(f, *args, **kwargs):
496498
)
497499
span.__enter__()
498500

501+
set_data_normalized(span, SPANDATA.GEN_AI_SYSTEM, "openai")
499502
set_data_normalized(span, SPANDATA.GEN_AI_REQUEST_MODEL, model)
503+
set_data_normalized(span, SPANDATA.GEN_AI_OPERATION_NAME, "responses")
500504

501505
if should_send_default_pii() and integration.include_prompts:
502506
set_data_normalized(span, SPANDATA.GEN_AI_REQUEST_MESSAGES, input)

0 commit comments

Comments
 (0)