explanation of defeat

Author: antonpirker

sentry_sdk/integrations/openai_agents/patches/runner.py

@@ -44,7 +44,8 @@ async def async_wrapper(cls, *args, **kwargs):
             except Exception as exc:
                 _capture_exception(exc)
 
-                # It could be that there is a "invoke agent" span still open (because its create in run_hooks)
+                # It could be that there is a "invoke agent" span still open
+                # (because its create in run_hooks without the context manager)
                 current_span = sentry_sdk.get_current_span()
                 if current_span.timestamp is None:
                     current_span.__exit__(None, None, None)

sentry_sdk/integrations/openai_agents/patches/tools.py

@@ -48,6 +48,13 @@ def create_wrapped_invoke(current_tool, current_on_invoke):
                 async def sentry_wrapped_on_invoke_tool(*args, **kwargs):
                     # type: (*Any, **Any) -> Any
                     with execute_tool_span(current_tool, *args, **kwargs) as span:
+                        # We can not capture exceptions in tool execution here because
+                        # `_on_invoke_tool` is swallowing the exception here:
+                        # https://github.com/openai/openai-agents-python/blob/main/src/agents/tool.py#L409-L422
+                        # And because function_tool is a decorator with `default_tool_error_function` set as a default parameter
+                        # I was unable to monkey patch it because those are evaluated at module import time
+                        # and the SDK is too late to patch it. I was also unable to patch `_on_invoke_tool_impl`
+                        # because it is nested inside this import time code. As if they made it hard to patch on purpose...
                         result = await current_on_invoke(*args, **kwargs)
                         update_execute_tool_span(span, agent, current_tool, result)