clean up Cursor's solution

Author: szokeasaurusrex

CHANGES_SUMMARY.md

@@ -870,7 +870,8 @@ def set_tags(self, tags):
         This method only modifies tag keys in the `tags` mapping passed to the method.
         `scope.set_tags({})` is, therefore, a no-op.
 
-        :param tags: A mapping of tag keys to tag values to set. Values will be converted to strings.
+        :param tags: A mapping of tag keys to tag values to set. Values will be
+        converted to strings.
         """
         for key, value in tags.items():
             self.set_tag(key, value)

PR_SUMMARY.md

@@ -1270,7 +1270,16 @@ def iter_headers(self):
 
     def set_tag(self, key, value):
         # type: (str, Any) -> None
-        self._tags[key] = safe_str(value)
+        pass
+
+    def set_data(self, key, value):
+        # type: (str, Any) -> None
+        pass
+
+    def set_status(self, value):
+        # type: (str) -> None
+        pass
+
     def set_http_status(self, http_status):
         # type: (int) -> None
         pass

sentry_sdk/scope.py

@@ -190,48 +190,50 @@ def test_set_tags(sentry_init, capture_events):
     }, "Updating tags with empty dict changed tags"
 
 
-def test_set_tag_converts_to_string(sentry_init, capture_events):
+@pytest.mark.parametrize(
+    ("key", "value", "expected"),
+    [
+        ("int", 123, "123"),
+        ("float", 123.456, "123.456"),
+        ("bool", True, "True"),
+        ("none", None, "None"),
+        ("list", [1, 2, 3], "[1, 2, 3]"),
+    ],
+)
+def test_set_tag_converts_to_string(sentry_init, capture_events, key, value, expected):
     """Test that the api.set_tag function converts values to strings."""
     sentry_init()
     events = capture_events()
 
-    # Test various types
-    set_tag("int", 123)
-    set_tag("float", 123.456)
-    set_tag("bool", True)
-    set_tag("none", None)
-    set_tag("list", [1, 2, 3])
-    
+    set_tag(key, value)
     raise_and_capture()
-    
-    (*_, event) = events
+
+    (event,) = events
     tags = event.get("tags", {})
-    
-    assert tags["int"] == "123"
-    assert tags["float"] == "123.456"
-    assert tags["bool"] == "True"
-    assert tags["none"] == "None"
-    assert tags["list"] == "[1, 2, 3]"
+
+    assert tags[key] == expected
 
 
 def test_set_tags_converts_to_string(sentry_init, capture_events):
     """Test that the api.set_tags function converts values to strings."""
     sentry_init()
     events = capture_events()
 
-    set_tags({
-        "int": 456,
-        "float": 789.012,
-        "bool": False,
-        "tuple": (1, 2, 3),
-        "string": "already_string",
-    })
-    
+    set_tags(
+        {
+            "int": 456,
+            "float": 789.012,
+            "bool": False,
+            "tuple": (1, 2, 3),
+            "string": "already_string",
+        }
+    )
+
     raise_and_capture()
-    
+
     (*_, event) = events
     tags = event.get("tags", {})
-    
+
     assert tags["int"] == "456"
     assert tags["float"] == "789.012"
     assert tags["bool"] == "False"

sentry_sdk/tracing.py

@@ -907,12 +907,9 @@ def test_last_event_id_cleared(sentry_init):
     assert Scope.last_event_id() is None, "last_event_id should be cleared"
 
 
-def test_set_tag_converts_to_string():
-    """Test that set_tag converts various types to strings."""
-    scope = Scope()
-    
-    # Test various types
-    test_cases = [
+@pytest.mark.parametrize(
+    ("key", "value", "expected"),
+    [
         ("int", 123, "123"),
         ("float", 123.456, "123.456"),
         ("bool_true", True, "True"),
@@ -921,34 +918,37 @@ def test_set_tag_converts_to_string():
         ("list", [1, 2, 3], "[1, 2, 3]"),
         ("dict", {"key": "value"}, "{'key': 'value'}"),
         ("already_string", "test", "test"),
-    ]
-    
-    for key, value, expected in test_cases:
-        scope.set_tag(key, value)
-        
+    ],
+)
+def test_set_tag_converts_to_string(key, value, expected):
+    """Test that set_tag converts various types to strings."""
+    scope = Scope()
+    scope.set_tag(key, value)
+
     event = scope.apply_to_event({}, {})
     tags = event.get("tags", {})
-    
-    for key, value, expected in test_cases:
-        assert tags[key] == expected, f"Tag {key} was not converted properly"
+
+    assert tags[key] == expected, f"Tag {key} was not converted properly"
 
 
 def test_set_tags_converts_to_string():
     """Test that set_tags converts all values to strings."""
     scope = Scope()
-    
-    scope.set_tags({
-        "int": 123,
-        "float": 123.456,
-        "bool": True,
-        "none": None,
-        "list": [1, 2, 3],
-        "string": "test",
-    })
-    
+
+    scope.set_tags(
+        {
+            "int": 123,
+            "float": 123.456,
+            "bool": True,
+            "none": None,
+            "list": [1, 2, 3],
+            "string": "test",
+        }
+    )
+
     event = scope.apply_to_event({}, {})
     tags = event.get("tags", {})
-    
+
     assert tags["int"] == "123"
     assert tags["float"] == "123.456"
     assert tags["bool"] == "True"
@@ -960,52 +960,52 @@ def test_set_tags_converts_to_string():
 def test_set_tag_handles_conversion_failure():
     """Test that set_tag handles objects that fail to convert to string."""
     scope = Scope()
-    
+
     # Create an object that raises an exception when str() is called
     class BadObject:
         def __str__(self):
             raise Exception("Cannot convert to string")
-    
+
+        def __repr__(self):
+            return "BadObject()"
+
     bad_obj = BadObject()
-    
+
     # This should not raise an exception
     scope.set_tag("bad_object", bad_obj)
-    
-    # The tag should not be set
-    event = scope.apply_to_event({}, {})
-    tags = event.get("tags", {})
-    
-    assert "bad_object" not in tags, "Tag with failed conversion should not be set"
-    
-    # Other tags should still work
-    scope.set_tag("good_tag", "value")
+
+    # The tag should be set with the repr value
     event = scope.apply_to_event({}, {})
     tags = event.get("tags", {})
-    
-    assert tags["good_tag"] == "value"
+
+    assert tags["bad_object"] == "BadObject()", "Tag should be set with repr value"
 
 
 def test_set_tags_handles_conversion_failure():
     """Test that set_tags handles objects that fail to convert to string."""
     scope = Scope()
-    
+
     # Create an object that raises an exception when str() is called
     class BadObject:
         def __str__(self):
             raise Exception("Cannot convert to string")
-    
+
+        def __repr__(self):
+            return "BadObject()"
+
     bad_obj = BadObject()
-    
-    # This should not raise an exception and should set the convertible tags
-    scope.set_tags({
-        "good_tag1": "value1",
-        "bad_tag": bad_obj,
-        "good_tag2": 123,
-    })
-    
+
+    scope.set_tags(
+        {
+            "good_tag1": "value1",
+            "bad_tag": bad_obj,
+            "good_tag2": 123,
+        }
+    )
+
     event = scope.apply_to_event({}, {})
     tags = event.get("tags", {})
-    
+
     assert tags["good_tag1"] == "value1"
-    assert "bad_tag" not in tags
+    assert tags["bad_tag"] == "BadObject()", "Tag should be set with repr value"
     assert tags["good_tag2"] == "123"