Ignore non-str notes

Author: szokeasaurusrex

sentry_sdk/utils.py

@@ -717,10 +717,12 @@ def get_error_message(exc_value):
         getattr(exc_value, "message", "")
         or getattr(exc_value, "detail", "")
         or safe_str(exc_value)
-    )
-    notes = getattr(exc_value, "__notes__", [])
-    if notes:
-        value = "\n".join([value] + [safe_str(note) for note in notes])
+    )  # type: str
+
+    notes = getattr(exc_value, "__notes__", None)  # type: object
+    if isinstance(notes, list) and len(notes) > 0:
+        value += "\n" + "\n".join(note for note in notes if isinstance(note, str))
+
     return value
 
 

tests/test_basics.py

@@ -1008,13 +1008,14 @@ def test_notes(sentry_init, capture_events):
     try:
         e = ValueError("aha!")
         e.add_note("Test 123")
+        e.add_note("another note")
         raise e
     except Exception:
         capture_exception()
 
     (event,) = events
 
-    assert event["exception"]["values"][0]["value"] == "aha!\nTest 123"
+    assert event["exception"]["values"][0]["value"] == "aha!\nTest 123\nanother note"
 
 
 @pytest.mark.skipif(sys.version_info < (3, 11), reason="add_note() not supported")
@@ -1033,13 +1034,11 @@ def __str__(self):
         e.add_note("note 1")
         e.__notes__.append(Note2())  # type: ignore
         e.add_note("note 3")
+        e.__notes__.append(2)  # type: ignore
         raise e
     except Exception:
         capture_exception()
 
     (event,) = events
 
-    assert (
-        event["exception"]["values"][0]["value"]
-        == "aha!\nnote 1\n<broken repr>\nnote 3"
-    )
+    assert event["exception"]["values"][0]["value"] == "aha!\nnote 1\nnote 3"