Skip to content

Commit b44f195

Browse files
committed
rename
1 parent 04a2ab6 commit b44f195

File tree

2 files changed

+14
-10
lines changed

2 files changed

+14
-10
lines changed

scripts/populate_tox/dependencies.py

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
1-
# The DEPENDENCIES dictionary defines the test dependencies of each integration
2-
# test suite.
1+
# The TEST_SUITE_CONFIG dictionary defines, for each integration test suite,
2+
# the main package (framework, library) to test with; any additional test
3+
# dependencies, optionally gated behind specific conditions; and optionally
4+
# the Python versions to test on.
35
#
46
# The format is:
57
# ```
@@ -8,14 +10,15 @@
810
# "deps": {
911
# rule1: [package1, package2, ...],
1012
# rule2: [package3, package4, ...],
11-
# }
13+
# },
14+
# "python": python_version_specifier,
1215
# }
1316
# ```
1417
#
1518
# The following can be set as a rule:
1619
# - `*`: packages will be always installed
17-
# - a version bound on the main package (e.g. `<=0.32`): packages will only be
18-
# installed if the main package falls into the version bounds specified
20+
# - a version specifier on the main package (e.g. `<=0.32`): packages will only
21+
# be installed if the main package falls into the version bounds specified
1922
# - specific Python version(s) in the form `py3.8,py3.9`: packages will only be
2023
# installed if the Python version matches one from the list
2124
#
@@ -34,7 +37,7 @@
3437
# ````
3538

3639

37-
DEPENDENCIES = {
40+
TEST_SUITE_CONFIG = {
3841
"ariadne": {
3942
"package": "ariadne",
4043
"deps": {

scripts/populate_tox/populate_tox.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
from sentry_sdk.integrations import _MIN_VERSIONS
1818

19-
from dependencies import DEPENDENCIES
19+
from dependencies import TEST_SUITE_CONFIG
2020
from scripts.split_tox_gh_actions.split_tox_gh_actions import GROUPS
2121

2222

@@ -41,7 +41,8 @@
4141
#
4242
# This set should be getting smaller over time as we migrate more test
4343
# suites over to this script. Some entries will probably stay forever
44-
# as they don't fit the mold (e.g. common, asgi).
44+
# as they don't fit the mold (e.g. common, asgi, which don't have a 3rd party
45+
# pypi package to install in different versions).
4546
"aiohttp",
4647
"anthropic",
4748
"asgi",
@@ -314,7 +315,7 @@ def _render_python_versions(python_versions: list[Version]) -> str:
314315

315316
def _render_dependencies(integration: str, releases: list[Version]) -> list[str]:
316317
rendered = []
317-
for constraint, deps in DEPENDENCIES[integration]["deps"].items():
318+
for constraint, deps in TEST_SUITE_CONFIG[integration]["deps"].items():
318319
if constraint == "*":
319320
for dep in deps:
320321
rendered.append(f"{integration}: {dep}")
@@ -376,7 +377,7 @@ def write_tox_file(packages: dict) -> None:
376377
print(f"Processing {integration}...")
377378

378379
# Figure out the actual main package
379-
package = DEPENDENCIES[integration]["package"]
380+
package = TEST_SUITE_CONFIG[integration]["package"]
380381
extra = None
381382
if "[" in package:
382383
extra = package[package.find("[") + 1 : package.find("]")]

0 commit comments

Comments
 (0)