.

Author: sentrivana

scripts/split_tox_gh_actions/split_tox_gh_actions.py

@@ -26,7 +26,18 @@
 
 from jinja2 import Environment, FileSystemLoader
 
-VERSION_REGEX = re.compile(r"v{?[0-9.]+.*}?|latest")
+TOXENV_REGEX = re.compile(
+    r"""
+    {?(?P<py_versions>(py\d+\.\d+,?)+)}?
+    -(?P<framework>[a-z](?:[a-z_]|-(?!v{?\d|latest))*[a-z0-9])
+    (?:-(
+        (v{?(?P<framework_versions>[0-9.]+[0-9a-z,.]*}?))
+        |
+        (?P<framework_versions_latest>latest)
+    ))?
+""",
+    re.VERBOSE,
+)
 
 OUT_DIR = Path(__file__).resolve().parent.parent.parent / ".github" / "workflows"
 TOX_FILE = Path(__file__).resolve().parent.parent.parent / "tox.ini"
@@ -211,33 +222,26 @@ def parse_tox():
         line = line.strip().lower()
 
         try:
-            # Parse tox environment definitions.
-            # The format is pythonversions-integrationname-integrationversions.
-            # Some valid examples:
-            # {pyX.Y,pyX.Z}-integrationname-vA.B.C
-            # {pyX.Y,pyX.Z}-integrationname-v{A.B.C}
-            # {pyX.Y,pyX.Z}-integrationname
-            # No that integrationname can also contain dashes, which makes this a
-            # bit more annoying.
-            raw_python_versions = line.split("-")[0]
-            framework_versions = line.rsplit("-", maxsplit=1)[-1]
-            framework = line[
-                len(raw_python_versions) + 1 : -(len(framework_versions) + 1)
-            ]
-            if not VERSION_REGEX.match(framework_versions):
-                (raw_python_versions, framework) = line.split("-")
-                framework_versions = []
+            # parse tox environment definition
+            parsed = TOXENV_REGEX.match(line)
+            if not parsed:
+                print(f"ERROR reading line {line}")
+                raise ValueError("Failed to parse tox environment definition")
+
+            groups = parsed.groupdict()
+            raw_python_versions = groups["py_versions"]
+            framework = groups["framework"]
+            framework_versions_latest = groups.get("framework_versions_latest") or False
 
             # collect python versions to test the framework in
-            raw_python_versions = set(
-                raw_python_versions.replace("{", "").replace("}", "").split(",")
-            )
-            if "latest" in framework_versions:
+            raw_python_versions = set(raw_python_versions.split(","))
+            if framework_versions_latest:
                 py_versions_latest[framework] |= raw_python_versions
             else:
                 py_versions_pinned[framework] |= raw_python_versions
 
-        except ValueError:
+        except Exception:
+            raise
             print(f"ERROR reading line {line}")
             parsed_correctly = False