Skip to content

Commit c234dd4

Browse files
committed
typing
1 parent cfec8c0 commit c234dd4

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

sentry_sdk/tracing.py

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -599,14 +599,17 @@ def set_tag(self, key, value):
599599
# type: (str, Any) -> None
600600
self._tags[key] = value
601601

602-
def set_data(self, key, value=None):
603-
# type: (Union[str, Dict[str, Any]], Any) -> None
602+
def set_data(self, key=None, value=None):
603+
# type: (Optional[Union[str, Dict[str, Any]]], Optional[Any]) -> None
604604
"""Set data on the span.
605605
606606
Can be called in two ways:
607607
- set_data(key, value) - sets a single key-value pair
608608
- set_data({"key": "value"}) - sets multiple key-value pairs from a dict
609609
"""
610+
if key is None:
611+
return
612+
610613
if isinstance(key, dict):
611614
# Dictionary calling pattern: set_data({"key": "value"})
612615
for k, v in key.items():
@@ -1285,8 +1288,8 @@ def set_tag(self, key, value):
12851288
# type: (str, Any) -> None
12861289
pass
12871290

1288-
def set_data(self, key, value=None):
1289-
# type: (Union[str, Dict[str, Any]], Any) -> None
1291+
def set_data(self, key=None, value=None):
1292+
# type: (Optional[Union[str, Dict[str, Any]]], Optional[Any]) -> None
12901293
pass
12911294

12921295
def set_status(self, value):
@@ -1349,19 +1352,19 @@ def _set_initial_sampling_decision(self, sampling_context):
13491352
def trace(
13501353
func=None, *, template=SpanTemplate.SPAN, op=None, name=None, attributes=None
13511354
):
1352-
# type: (Optional[Callable[P, R]], ..., Optional[str], Optional[str], Optional[dict[str, Any]]) -> Union[Callable[P, R], Callable[[Callable[P, R]], Callable[P, R]]]
1355+
# type: (Optional[Callable[P, R]], SpanTemplate, Optional[str], Optional[str], Optional[dict[str, Any]]) -> Callable[[Callable[P, R]], Callable[P, R]]
13531356
pass
13541357

13551358
@overload
13561359
def trace(func, *, template=SpanTemplate.SPAN, op=None, name=None, attributes=None):
1357-
# type: (Callable[P, R], ..., Optional[str], Optional[str], Optional[dict[str, Any]]) -> Union[Callable[P, R], Callable[[Callable[P, R]], Callable[P, R]]]
1360+
# type: (Callable[P, R], SpanTemplate, Optional[str], Optional[str], Optional[dict[str, Any]]) -> Callable[P, R]
13581361
pass
13591362

13601363

13611364
def trace(
13621365
func=None, *, template=SpanTemplate.SPAN, op=None, name=None, attributes=None
13631366
):
1364-
# type: (Optional[Callable[P, R]], ..., Optional[str], Optional[str], Optional[dict[str, Any]]) -> Union[Callable[P, R], Callable[[Callable[P, R]], Callable[P, R]]]
1367+
# type: (Optional[Callable[P, R]], SpanTemplate, Optional[str], Optional[str], Optional[dict[str, Any]]) -> Union[Callable[P, R], Callable[[Callable[P, R]], Callable[P, R]]]
13651368
"""
13661369
Decorator to start a child span.
13671370

0 commit comments

Comments
 (0)