Rename _get_pipeline_data to _set_pipeline_data

Author: antonpirker

sentry_sdk/integrations/redis/_async_common.py

@@ -8,7 +8,7 @@
 from sentry_sdk.integrations.redis.modules.queries import _compile_db_span_properties
 from sentry_sdk.integrations.redis.utils import (
     _set_client_data,
-    _set_pipeline_data,
+    _get_pipeline_data,
 )
 from sentry_sdk.tracing import Span
 from sentry_sdk.utils import capture_internal_exceptions
@@ -42,12 +42,11 @@ async def _sentry_execute(self, *args, **kwargs):
         ) as span:
             with capture_internal_exceptions():
                 span_data = get_db_data_fn(self)
-                _set_pipeline_data(
-                    span,
-                    is_cluster,
-                    get_command_args_fn,
-                    False if is_cluster else self.is_transaction,
-                    self._command_stack if is_cluster else self.command_stack,
+                pipeline_data = _get_pipeline_data(
+                    is_cluster=is_cluster,
+                    get_command_args_fn=get_command_args_fn,
+                    is_transaction=False if is_cluster else self.is_transaction,
+                    command_stack=self._command_stack if is_cluster else self.command_stack,
                 )
 
             return await old_execute(self, *args, **kwargs)

sentry_sdk/integrations/redis/_sync_common.py

@@ -8,7 +8,7 @@
 from sentry_sdk.integrations.redis.modules.queries import _compile_db_span_properties
 from sentry_sdk.integrations.redis.utils import (
     _set_client_data,
-    _set_pipeline_data,
+    _get_pipeline_data,
 )
 from sentry_sdk.tracing import Span
 from sentry_sdk.utils import capture_internal_exceptions
@@ -44,12 +44,11 @@ def sentry_patched_execute(self, *args, **kwargs):
         ) as span:
             with capture_internal_exceptions():
                 span_data = get_db_data_fn(self)
-                _set_pipeline_data(
-                    span,
-                    is_cluster,
-                    get_command_args_fn,
-                    False if is_cluster else self.transaction,
-                    self.command_stack,
+                pipeline_data = _get_pipeline_data(
+                    is_cluster=is_cluster,
+                    get_command_args_fn=get_command_args_fn,
+                    is_transaction=False if is_cluster else self.transaction,
+                    command_stack=self.command_stack,
                 )
 
             return old_execute(self, *args, **kwargs)

sentry_sdk/integrations/redis/utils.py

@@ -105,12 +105,14 @@ def _parse_rediscluster_command(command):
     return command.args
 
 
-def _set_pipeline_data(
-    span, is_cluster, get_command_args_fn, is_transaction, command_stack
+def _get_pipeline_data(
+    is_cluster, get_command_args_fn, is_transaction, command_stack
 ):
-    # type: (Span, bool, Any, bool, Sequence[Any]) -> None
-    span.set_tag("redis.is_cluster", is_cluster)
-    span.set_tag("redis.transaction", is_transaction)
+    # type: (bool, Any, bool, Sequence[Any]) -> dict[str, Any]
+    data = {
+        "redis.is_cluster": is_cluster,
+        "redis.transaction": is_transaction,
+    }
 
     commands = []
     for i, arg in enumerate(command_stack):
@@ -120,8 +122,10 @@ def _set_pipeline_data(
         command = get_command_args_fn(arg)
         commands.append(_get_safe_command(command[0], command[1:]))
 
-    span.set_data("redis.commands.count", len(command_stack))
-    span.set_data("redis.commands.first_ten", commands)
+    data["redis.commands.count"] = len(command_stack)
+    data["redis.commands.first_ten"] = commands
+
+    return data
 
 
 def _set_client_data(span, is_cluster, name, *args):