Some cleanup and some tests

Author: antonpirker

sentry_sdk/_lru_cache.py

@@ -181,14 +181,8 @@ def get_all(self):
         nodes = []
         node = self.root[NEXT]
 
-        # To ensure the loop always terminates we iterate to the maximum
-        # size of the LRU cache.
-        for _ in range(self.max_size):
-            # The cache may not be full. We exit early if we've wrapped
-            # around to the head.
-            if node is self.root:
-                break
+        while node is not self.root:
             nodes.append((node[KEY], node[VALUE]))
             node = node[NEXT]
 
-        return nodes
+        return nodes

tests/test_lru_cache.py

@@ -1,5 +1,5 @@
 import pytest
-from copy import copy
+from copy import copy, deepcopy
 
 from sentry_sdk._lru_cache import LRUCache
 
@@ -76,3 +76,38 @@ def test_cache_copy():
     cache.get(1)
     assert copied.get_all() == [(1, 1), (2, 2), (3, 3)]
     assert cache.get_all() == [(2, 2), (3, 3), (1, 1)]
+
+
+def test_cache_deepcopy():
+    cache = LRUCache(3)
+    cache.set(0, 0)
+    cache.set(1, 1)
+
+    copied = deepcopy(cache)
+    cache.set(2, 2)
+    cache.set(3, 3)
+    assert copied.get_all() == [(0, 0), (1, 1)]
+    assert cache.get_all() == [(1, 1), (2, 2), (3, 3)]
+
+    copied = deepcopy(cache)
+    cache.get(1)
+    assert copied.get_all() == [(1, 1), (2, 2), (3, 3)]
+    assert cache.get_all() == [(2, 2), (3, 3), (1, 1)]
+
+
+def test_cache_pollution():
+    cache1 = LRUCache(max_size=2)
+    cache1.set(1, True)
+    cache2 = copy(cache1)
+    cache2.set(1, False)
+    assert cache1.get(1) is True
+    assert cache2.get(1) is False
+
+
+def test_cache_pollution_deepcopy():
+    cache1 = LRUCache(max_size=2)
+    cache1.set(1, True)
+    cache2 = deepcopy(cache1)
+    cache2.set(1, False)
+    assert cache1.get(1) is True
+    assert cache2.get(1) is False

tests/test_scope.py

@@ -43,6 +43,28 @@ def test_all_slots_copied():
         assert getattr(scope_copy, attr) == getattr(scope, attr)
 
 
+def test_scope_flags_copy():
+    # Assert forking creates a deepcopy of the flag buffer. The new
+    # scope is free to mutate without consequence to the old scope. The
+    # old scope is free to mutate without consequence to the new scope.
+    old_scope = Scope()
+    old_scope.flags.set("a", True)
+
+    new_scope = old_scope.fork()
+    new_scope.flags.set("a", False)
+    old_scope.flags.set("b", True)
+    new_scope.flags.set("c", True)
+
+    assert old_scope.flags.get() == [
+        {"flag": "a", "result": True},
+        {"flag": "b", "result": True},
+    ]
+    assert new_scope.flags.get() == [
+        {"flag": "a", "result": False},
+        {"flag": "c", "result": True},
+    ]
+
+
 def test_merging(sentry_init, capture_events):
     sentry_init()