Add threaded, asyncio, and global ldclient tests

Author: aliu39

tests/integrations/launchdarkly/test_launchdarkly.py

@@ -1,4 +1,10 @@
+import asyncio
+import concurrent.futures as cf
+
+import ldclient
+
 import sentry_sdk
+import pytest
 
 from ldclient import LDClient
 from ldclient.config import Config
@@ -8,25 +14,84 @@
 from sentry_sdk.integrations.launchdarkly import LaunchDarklyIntegration
 
 # Ref: https://docs.launchdarkly.com/sdk/features/test-data-sources#python
+# https://launchdarkly-python-sdk.readthedocs.io/en/latest/api-testing.html#ldclient.integrations.test_data.TestData
 
 
-def test_launchdarkly_integration(sentry_init):
+@pytest.mark.parametrize(
+    "use_global_client",
+    (False, True),
+)
+def test_launchdarkly_integration(sentry_init, use_global_client):
     td = TestData.data_source()
-    client = LDClient(config=Config("sdk-key", update_processor_class=td))
-    sentry_init(integrations=[LaunchDarklyIntegration(client=client)])
+    config = Config("sdk-key", update_processor_class=td)
+    if use_global_client:
+        ldclient.set_config(config)
+        sentry_init(integrations=[LaunchDarklyIntegration()])
+        client = ldclient.get()
+    else:
+        client = LDClient(config=config)
+        sentry_init(integrations=[LaunchDarklyIntegration(client=client)])
 
     # Set test values
     td.update(td.flag("hello").variation_for_all(True))
     td.update(td.flag("world").variation_for_all(True))
-    td.update(td.flag("goodbye").variation_for_all(False))
 
     # Evaluate
     client.variation("hello", Context.create("my-org", "organization"), False)
     client.variation("world", Context.create("user1", "user"), False)
-    client.variation("goodbye", Context.create("user2", "user"), False)
+    client.variation("other", Context.create("user2", "user"), False)
 
     assert sentry_sdk.get_current_scope().flags.get() == [
         {"flag": "hello", "result": True},
         {"flag": "world", "result": True},
-        {"flag": "goodbye", "result": False},
+        {"flag": "other", "result": False},
     ]
+
+
+def test_launchdarkly_integration_threaded(sentry_init):
+    td = TestData.data_source()
+    client = LDClient(config=Config("sdk-key", update_processor_class=td))
+    sentry_init(integrations=[LaunchDarklyIntegration(client=client)])
+    context = Context.create("user1")
+
+    def task(flag_key):
+        # Create a new isolation scope for the thread. This means the evaluations in each task are captured separately.
+        with sentry_sdk.isolation_scope():
+            client.variation(flag_key, context, False)
+            return [f["flag"] for f in sentry_sdk.get_current_scope().flags.get()]
+
+    td.update(td.flag("hello").variation_for_all(True))
+    td.update(td.flag("world").variation_for_all(False))
+    client.variation(
+        "hello", context, False
+    )  # Captured before splitting isolation scopes.
+
+    with cf.ThreadPoolExecutor(max_workers=2) as pool:
+        results = list(pool.map(task, ["world", "other"]))
+
+    assert results[0] == ["hello", "world"]
+    assert results[1] == ["hello", "other"]
+
+
+def test_launchdarkly_integration_asyncio(sentry_init):
+    """Assert concurrently evaluated flags do not pollute one another."""
+    td = TestData.data_source()
+    client = LDClient(config=Config("sdk-key", update_processor_class=td))
+    sentry_init(integrations=[LaunchDarklyIntegration(client=client)])
+    context = Context.create("user1")
+
+    async def task(flag_key):
+        with sentry_sdk.isolation_scope():
+            client.variation(flag_key, context, False)
+            return [f["flag"] for f in sentry_sdk.get_current_scope().flags.get()]
+
+    async def runner():
+        return asyncio.gather(task("world"), task("other"))
+
+    td.update(td.flag("hello").variation_for_all(True))
+    td.update(td.flag("world").variation_for_all(False))
+    client.variation("hello", context, False)
+
+    results = asyncio.run(runner()).result()
+    assert results[0] == ["hello", "world"]
+    assert results[1] == ["hello", "other"]