More test cases

Author: antonpirker

tests/tracing/test_trace_propagation.py

@@ -28,7 +28,7 @@
 
 
 @pytest.fixture
-def mock_putheader(monkeypatch):
+def _mock_putheader(monkeypatch):
     """
     Mock HTTPConnection.putheader to capture calls to it.
     """
@@ -59,7 +59,7 @@ def mock_putheader_fn(self, header, value):
     ],
 )
 def test_trace_propagation_no_incoming_trace(
-    sentry_init, capture_events, mock_putheader, traces_sample_rate
+    sentry_init, capture_events, _mock_putheader, traces_sample_rate
 ):
     init_kwargs = {}
     if traces_sample_rate != USE_DEFAULT_TRACES_SAMPLE_RATE:
@@ -80,7 +80,7 @@ def test_trace_propagation_no_incoming_trace(
     else:
         assert len(events) == 0
 
-    outgoing_request_headers = {key: value for key, value in mock_putheader}
+    outgoing_request_headers = {key: value for key, value in _mock_putheader}
     assert "custom-header" in outgoing_request_headers
 
     # CHECK if trace information is added to the outgoing request
@@ -109,7 +109,7 @@ def test_trace_propagation_no_incoming_trace(
     ],
 )
 def test_trace_propagation_with_incoming_trace(
-    sentry_init, capture_events, mock_putheader, traces_sample_rate
+    sentry_init, capture_events, _mock_putheader, traces_sample_rate
 ):
     init_kwargs = {}
     if traces_sample_rate != USE_DEFAULT_TRACES_SAMPLE_RATE:
@@ -130,7 +130,7 @@ def test_trace_propagation_with_incoming_trace(
     else:
         assert len(events) == 0
 
-    outgoing_request_headers = {key: value for key, value in mock_putheader}
+    outgoing_request_headers = {key: value for key, value in _mock_putheader}
     assert "custom-header" in outgoing_request_headers
 
     # CHECK if trace information is added to the outgoing request
@@ -146,3 +146,101 @@ def test_trace_propagation_with_incoming_trace(
         # do NOT continue the incoming trace
         assert INCOMING_TRACE_ID not in outgoing_request_headers["sentry-trace"]
         assert INCOMING_TRACE_ID not in outgoing_request_headers["baggage"]
+
+
+@pytest.mark.parametrize(
+    "traces_sample_rate",
+    [
+        USE_DEFAULT_TRACES_SAMPLE_RATE,
+        None,
+        0,
+        1.0,
+    ],
+    ids=[
+        "default traces_sample_rate",
+        "traces_sample_rate=None",
+        "traces_sample_rate=0",
+        "traces_sample_rate=1",
+    ],
+)
+def test_trace_propagation_no_incoming_trace_and_targets_not_matching(
+    sentry_init, capture_events, _mock_putheader, traces_sample_rate
+):
+    init_kwargs = {
+        "trace_propagation_targets": [
+            "http://someothersite.com",
+        ],
+    }
+    if traces_sample_rate != USE_DEFAULT_TRACES_SAMPLE_RATE:
+        init_kwargs["traces_sample_rate"] = traces_sample_rate
+    sentry_init(**init_kwargs)
+
+    events = capture_events()
+
+    with sentry_sdk.continue_trace({}):
+        with sentry_sdk.start_span(op="test", name="test"):
+            requests.get(
+                "http://example.com", headers={"custom-header": "custom-value"}
+            )
+
+    # CHECK if performance data (a transaction/span) is sent to Sentry
+    if traces_sample_rate == 1:
+        assert len(events) == 1
+    else:
+        assert len(events) == 0
+
+    outgoing_request_headers = {key: value for key, value in _mock_putheader}
+    assert "custom-header" in outgoing_request_headers
+
+    # CHECK if trace information is added to the outgoing request
+    assert "sentry-trace" not in outgoing_request_headers
+    assert "baggage" not in outgoing_request_headers
+
+
+@pytest.mark.parametrize(
+    "traces_sample_rate",
+    [
+        USE_DEFAULT_TRACES_SAMPLE_RATE,
+        None,
+        0,
+        1.0,
+    ],
+    ids=[
+        "default traces_sample_rate",
+        "traces_sample_rate=None",
+        "traces_sample_rate=0",
+        "traces_sample_rate=1",
+    ],
+)
+def test_trace_propagation_with_incoming_trace_and_targets_not_matching(
+    sentry_init, capture_events, _mock_putheader, traces_sample_rate
+):
+    init_kwargs = {
+        "trace_propagation_targets": [
+            "http://someothersite.com",
+        ],
+    }
+    if traces_sample_rate != USE_DEFAULT_TRACES_SAMPLE_RATE:
+        init_kwargs["traces_sample_rate"] = traces_sample_rate
+    sentry_init(**init_kwargs)
+
+    events = capture_events()
+
+    with sentry_sdk.continue_trace(INCOMING_HEADERS):
+        with sentry_sdk.start_span(op="test", name="test"):
+            requests.get(
+                "http://example.com", headers={"custom-header": "custom-value"}
+            )
+
+    # CHECK if performance data (a transaction/span) is sent to Sentry
+    if traces_sample_rate == 1:
+        assert len(events) == 1
+    else:
+        assert len(events) == 0
+
+    outgoing_request_headers = {key: value for key, value in _mock_putheader}
+    assert "custom-header" in outgoing_request_headers
+
+    # CHECK if trace information is added to the outgoing request
+    assert "sentry-trace" not in outgoing_request_headers
+    assert "baggage" not in outgoing_request_headers