updated fallback

Author: antonpirker

sentry_sdk/integrations/django/__init__.py

@@ -1,6 +1,7 @@
 import sys
 import threading
 import weakref
+import inspect
 from importlib import import_module
 
 import sentry_sdk
@@ -763,24 +764,52 @@ def _set_db_data(span, cursor_or_db):
             span.set_data(SPANDATA.SERVER_SOCKET_ADDRESS, cached_config["unix_socket"])
         return
 
-    # Fallback to using get_connection_params()
+    # Fallback to using the database connection to get the data.
+    # This is the edge case where db configuration is not in Django's `DATABASES` setting.
     try:
-        connection_params = db.get_connection_params()
+        # Some custom backends override `__getattr__`, making it look like `cursor_or_db`
+        # actually has a `connection` and the `connection` has a `get_dsn_parameters`
+        # attribute, only to throw an error once you actually want to call it.
+        # Hence the `inspect` check whether `get_dsn_parameters` is an actual callable
+        # function.
+        is_psycopg2 = (
+            hasattr(cursor_or_db, "connection")
+            and hasattr(cursor_or_db.connection, "get_dsn_parameters")
+            and inspect.isroutine(cursor_or_db.connection.get_dsn_parameters)
+        )
+        if is_psycopg2:
+            connection_params = cursor_or_db.connection.get_dsn_parameters()
+        else:
+            try:
+                # psycopg3, only extract needed params as get_parameters
+                # can be slow because of the additional logic to filter out default
+                # values
+                connection_params = {
+                    "dbname": cursor_or_db.connection.info.dbname,
+                    "port": cursor_or_db.connection.info.port,
+                }
+                # PGhost returns host or base dir of UNIX socket as an absolute path
+                # starting with /, use it only when it contains host
+                host = cursor_or_db.connection.info.host
+                if host and not host.startswith("/"):
+                    connection_params["host"] = host
+            except Exception:
+                connection_params = db.get_connection_params()
 
         db_name = connection_params.get("dbname") or connection_params.get("database")
-        if db_name:
+        if db_name is not None:
             span.set_data(SPANDATA.DB_NAME, db_name)
 
         host = connection_params.get("host")
-        if host:
+        if host is not None:
             span.set_data(SPANDATA.SERVER_ADDRESS, host)
 
         port = connection_params.get("port")
-        if port:
+        if port is not None:
             span.set_data(SPANDATA.SERVER_PORT, str(port))
 
         unix_socket = connection_params.get("unix_socket")
-        if unix_socket:
+        if unix_socket is not None:
             span.set_data(SPANDATA.SERVER_SOCKET_ADDRESS, unix_socket)
 
     except (KeyError, ImproperlyConfigured, AttributeError) as e: