.

Author: alexander-alderman-webb

sentry_sdk/_metrics_batcher.py

@@ -77,6 +77,7 @@ def add(
         with self._lock:
             if len(self._metric_buffer) >= self.MAX_METRICS_BEFORE_DROP:
                 self._record_lost_func(
+                    reason="queue_overflow",
                     data_category="trace_metric",
                     quantity=1,
                 )

sentry_sdk/client.py

@@ -357,13 +357,14 @@ def _capture_envelope(envelope):
             if self.transport is not None:
                 self.transport.capture_envelope(envelope)
 
-        def _record_batcher_overflow_lost_event(
+        def _record_lost_event(
+            reason,  # type: str
             data_category,  # type: EventDataCategory
             quantity=1,  # type: int
         ):
             if self.transport is not None:
                 self.transport.record_lost_event(
-                    reason="queue_overflow",
+                    reason=reason,
                     data_category=data_category,
                     quantity=quantity,
                 )
@@ -390,7 +391,7 @@ def _record_batcher_overflow_lost_event(
             if has_metrics_enabled(self.options):
                 self.metrics_batcher = MetricsBatcher(
                     capture_func=_capture_envelope,
-                    record_lost_func=_record_batcher_overflow_lost_event,
+                    record_lost_func=_record_lost_event,
                 )
 
             max_request_body_size = ("always", "never", "small", "medium")

tests/test_metrics.py

@@ -217,8 +217,8 @@ def no_op_flush():
 
     lost_event_calls = []
 
-    def record_lost_event(reason, data_category=None, item=None, *, quantity=1):
-        lost_event_calls.append((reason, data_category, item, quantity))
+    def record_lost_event(reason, data_category, quantity):
+        lost_event_calls.append((reason, data_category, quantity))
 
     monkeypatch.setattr(client.metrics_batcher, "_record_lost_func", record_lost_event)
 
@@ -227,4 +227,4 @@ def record_lost_event(reason, data_category=None, item=None, *, quantity=1):
 
     assert len(lost_event_calls) == 5
     for lost_event_call in lost_event_calls:
-        assert lost_event_call == ("queue_overflow", "trace_metric", None, 1)
+        assert lost_event_call == ("queue_overflow", "trace_metric", 1)