Change metadata, test not enabled cases

Author: aliu39

sentry_sdk/integrations/launchdarkly.py

@@ -25,12 +25,14 @@ def __init__(self, client=None):
         # type: (LDClient | None) -> None
         if client is None:
             try:
-                client = ldclient.get()  # global singleton
+                client = (
+                    ldclient.get()
+                )  # global singleton. Fails if set_config hasn't been called.
             except Exception as exc:
                 raise DidNotEnable("Error getting LaunchDarkly client. " + repr(exc))
 
         if not client.is_initialized():
-            raise DidNotEnable("LaunchDarkly client is not initialized")
+            raise DidNotEnable("LaunchDarkly client is not initialized.")
 
         # Register the flag collection hook with the given client.
         client.add_hook(LaunchDarklyHook())
@@ -53,7 +55,7 @@ class LaunchDarklyHook(Hook):
     @property
     def metadata(self):
         # type: () -> Metadata
-        return Metadata(name="sentry-on-error-hook")
+        return Metadata(name="sentry-feature-flag-recorder")
 
     def after_evaluation(self, series_context, data, detail):
         # type: (EvaluationSeriesContext, dict[Any, Any], EvaluationDetail) -> dict[Any, Any]

tests/integrations/launchdarkly/test_launchdarkly.py

@@ -11,6 +11,7 @@
 from ldclient.context import Context
 from ldclient.integrations.test_data import TestData
 
+from sentry_sdk.integrations import DidNotEnable
 from sentry_sdk.integrations.launchdarkly import LaunchDarklyIntegration
 
 # Ref: https://docs.launchdarkly.com/sdk/features/test-data-sources#python
@@ -95,3 +96,23 @@ async def runner():
     results = asyncio.run(runner()).result()
     assert results[0] == ["hello", "world"]
     assert results[1] == ["hello", "other"]
+
+
+def test_launchdarkly_integration_did_not_enable(monkeypatch):
+    # Client is not passed in and set_config wasn't called.
+    # Bad practice to access internals like this. TODO: can skip this test, or remove this case entirely (force user to pass in a client instance).
+    ldclient._reset_client()
+    try:
+        ldclient.__lock.lock()
+        ldclient.__config = None
+    finally:
+        ldclient.__lock.unlock()
+
+    with pytest.raises(DidNotEnable):
+        LaunchDarklyIntegration()
+
+    # Client not initialized.
+    client = LDClient(config=Config("sdk-key"))
+    monkeypatch.setattr(client, "is_initialized", lambda: False)
+    with pytest.raises(DidNotEnable):
+        LaunchDarklyIntegration(client=client)