Skip to content

Commit dcb56d2

Browse files
authored
ref(tests): Remove debug=True from tests (#2934)
1 parent 867784d commit dcb56d2

File tree

11 files changed

+16
-31
lines changed

11 files changed

+16
-31
lines changed

tests/integrations/asgi/test_asgi.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -322,7 +322,7 @@ async def test_trace_from_headers_if_performance_disabled(
322322

323323
@pytest.mark.asyncio
324324
async def test_websocket(sentry_init, asgi3_ws_app, capture_events, request):
325-
sentry_init(debug=True, send_default_pii=True)
325+
sentry_init(send_default_pii=True)
326326

327327
events = capture_events()
328328

@@ -612,7 +612,6 @@ async def test_transaction_name(
612612
"""
613613
sentry_init(
614614
traces_sample_rate=1.0,
615-
debug=True,
616615
)
617616

618617
envelopes = capture_envelopes()
@@ -674,7 +673,6 @@ def dummy_traces_sampler(sampling_context):
674673
sentry_init(
675674
traces_sampler=dummy_traces_sampler,
676675
traces_sample_rate=1.0,
677-
debug=True,
678676
)
679677

680678
app = SentryAsgiMiddleware(asgi3_app, transaction_style=transaction_style)

tests/integrations/asyncio/test_asyncio.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@ async def test_create_task(
6767
sentry_init(
6868
traces_sample_rate=1.0,
6969
send_default_pii=True,
70-
debug=True,
7170
integrations=[
7271
AsyncioIntegration(),
7372
],
@@ -111,7 +110,6 @@ async def test_gather(
111110
sentry_init(
112111
traces_sample_rate=1.0,
113112
send_default_pii=True,
114-
debug=True,
115113
integrations=[
116114
AsyncioIntegration(),
117115
],
@@ -155,7 +153,6 @@ async def test_exception(
155153
sentry_init(
156154
traces_sample_rate=1.0,
157155
send_default_pii=True,
158-
debug=True,
159156
integrations=[
160157
AsyncioIntegration(),
161158
],

tests/integrations/celery/test_celery.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -361,7 +361,7 @@ def dummy_task(self):
361361
)
362362
@pytest.mark.forked
363363
def test_redis_backend_trace_propagation(init_celery, capture_events_forksafe):
364-
celery = init_celery(traces_sample_rate=1.0, backend="redis", debug=True)
364+
celery = init_celery(traces_sample_rate=1.0, backend="redis")
365365

366366
events = capture_events_forksafe()
367367

tests/integrations/falcon/test_falcon.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ def test_transaction_style(
112112

113113

114114
def test_unhandled_errors(sentry_init, capture_exceptions, capture_events):
115-
sentry_init(integrations=[FalconIntegration()], debug=True)
115+
sentry_init(integrations=[FalconIntegration()])
116116

117117
class Resource:
118118
def on_get(self, req, resp):
@@ -140,7 +140,7 @@ def on_get(self, req, resp):
140140

141141

142142
def test_raised_5xx_errors(sentry_init, capture_exceptions, capture_events):
143-
sentry_init(integrations=[FalconIntegration()], debug=True)
143+
sentry_init(integrations=[FalconIntegration()])
144144

145145
class Resource:
146146
def on_get(self, req, resp):
@@ -164,7 +164,7 @@ def on_get(self, req, resp):
164164

165165

166166
def test_raised_4xx_errors(sentry_init, capture_exceptions, capture_events):
167-
sentry_init(integrations=[FalconIntegration()], debug=True)
167+
sentry_init(integrations=[FalconIntegration()])
168168

169169
class Resource:
170170
def on_get(self, req, resp):
@@ -188,7 +188,7 @@ def test_http_status(sentry_init, capture_exceptions, capture_events):
188188
This just demonstrates, that if Falcon raises a HTTPStatus with code 500
189189
(instead of a HTTPError with code 500) Sentry will not capture it.
190190
"""
191-
sentry_init(integrations=[FalconIntegration()], debug=True)
191+
sentry_init(integrations=[FalconIntegration()])
192192

193193
class Resource:
194194
def on_get(self, req, resp):

tests/integrations/fastapi/test_fastapi.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@ async def test_response(sentry_init, capture_events):
5959
integrations=[StarletteIntegration(), FastApiIntegration()],
6060
traces_sample_rate=1.0,
6161
send_default_pii=True,
62-
debug=True,
6362
)
6463

6564
app = fastapi_app_factory()
@@ -196,7 +195,6 @@ async def test_original_request_not_scrubbed(sentry_init, capture_events):
196195
sentry_init(
197196
integrations=[StarletteIntegration(), FastApiIntegration()],
198197
traces_sample_rate=1.0,
199-
debug=True,
200198
)
201199

202200
app = FastAPI()
@@ -354,7 +352,6 @@ def test_transaction_name(
354352
FastApiIntegration(transaction_style=transaction_style),
355353
],
356354
traces_sample_rate=1.0,
357-
debug=True,
358355
)
359356

360357
envelopes = capture_envelopes()
@@ -384,7 +381,6 @@ def test_route_endpoint_equal_dependant_call(sentry_init):
384381
FastApiIntegration(),
385382
],
386383
traces_sample_rate=1.0,
387-
debug=True,
388384
)
389385

390386
app = fastapi_app_factory()
@@ -438,7 +434,6 @@ def dummy_traces_sampler(sampling_context):
438434
integrations=[StarletteIntegration(transaction_style=transaction_style)],
439435
traces_sampler=dummy_traces_sampler,
440436
traces_sample_rate=1.0,
441-
debug=True,
442437
)
443438

444439
app = fastapi_app_factory()
@@ -482,7 +477,6 @@ def test_transaction_name_in_middleware(
482477
FastApiIntegration(transaction_style=transaction_style),
483478
],
484479
traces_sample_rate=1.0,
485-
debug=True,
486480
)
487481

488482
envelopes = capture_envelopes()

tests/integrations/flask/test_flask.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ def test_errors(
125125
testing,
126126
integration_enabled_params,
127127
):
128-
sentry_init(debug=True, **integration_enabled_params)
128+
sentry_init(**integration_enabled_params)
129129

130130
app.debug = debug
131131
app.testing = testing

tests/integrations/huey/test_huey.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ def inner():
2020
integrations=[HueyIntegration()],
2121
traces_sample_rate=1.0,
2222
send_default_pii=True,
23-
debug=True,
2423
)
2524

2625
return MemoryHuey(name="sentry_sdk")

tests/integrations/quart/test_quart.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ async def test_errors(
129129
app,
130130
integration_enabled_params,
131131
):
132-
sentry_init(debug=True, **integration_enabled_params)
132+
sentry_init(**integration_enabled_params)
133133

134134
@app.route("/")
135135
async def index():

tests/integrations/starlette/test_starlette.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -954,7 +954,6 @@ def test_transaction_name(
954954
auto_enabling_integrations=False, # Make sure that httpx integration is not added, because it adds tracing information to the starlette test clients request.
955955
integrations=[StarletteIntegration(transaction_style=transaction_style)],
956956
traces_sample_rate=1.0,
957-
debug=True,
958957
)
959958

960959
envelopes = capture_envelopes()
@@ -1015,7 +1014,6 @@ def dummy_traces_sampler(sampling_context):
10151014
integrations=[StarletteIntegration(transaction_style=transaction_style)],
10161015
traces_sampler=dummy_traces_sampler,
10171016
traces_sample_rate=1.0,
1018-
debug=True,
10191017
)
10201018

10211019
app = starlette_app_factory()
@@ -1057,7 +1055,6 @@ def test_transaction_name_in_middleware(
10571055
StarletteIntegration(transaction_style=transaction_style),
10581056
],
10591057
traces_sample_rate=1.0,
1060-
debug=True,
10611058
)
10621059

10631060
envelopes = capture_envelopes()

tests/test_basics.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -439,7 +439,7 @@ def test_integration_scoping(sentry_init, capture_events):
439439
def test_client_initialized_within_scope(sentry_init, caplog):
440440
caplog.set_level(logging.WARNING)
441441

442-
sentry_init(debug=True)
442+
sentry_init()
443443

444444
with push_scope():
445445
Hub.current.bind_client(Client())
@@ -455,7 +455,7 @@ def test_client_initialized_within_scope(sentry_init, caplog):
455455
def test_scope_leaks_cleaned_up(sentry_init, caplog):
456456
caplog.set_level(logging.WARNING)
457457

458-
sentry_init(debug=True)
458+
sentry_init()
459459

460460
old_stack = list(Hub.current._stack)
461461

@@ -475,7 +475,7 @@ def test_scope_leaks_cleaned_up(sentry_init, caplog):
475475
def test_scope_popped_too_soon(sentry_init, caplog):
476476
caplog.set_level(logging.ERROR)
477477

478-
sentry_init(debug=True)
478+
sentry_init()
479479

480480
old_stack = list(Hub.current._stack)
481481

@@ -519,7 +519,7 @@ def bar(event, hint):
519519

520520

521521
def test_capture_event_with_scope_kwargs(sentry_init, capture_events):
522-
sentry_init(debug=True)
522+
sentry_init()
523523
events = capture_events()
524524
capture_event({}, level="info", extras={"foo": "bar"})
525525
(event,) = events

0 commit comments

Comments
 (0)