Convert boolean tags to strings in Redis and AWS Lambda integrations

Author: cursoragent

tests/integrations/aws_lambda/test_aws_lambda.py

@@ -325,10 +325,10 @@ def test_non_dict_event(
     assert transaction_event["request"] == request_data
 
     if batch_size > 1:
-        assert error_event["tags"]["batch_size"] == batch_size
-        assert error_event["tags"]["batch_request"] is True
-        assert transaction_event["tags"]["batch_size"] == batch_size
-        assert transaction_event["tags"]["batch_request"] is True
+        assert error_event["tags"]["batch_size"] == str(batch_size)
+        assert error_event["tags"]["batch_request"] == "True"
+        assert transaction_event["tags"]["batch_size"] == str(batch_size)
+        assert transaction_event["tags"]["batch_request"] == "True"
 
 
 def test_request_data(lambda_client, test_environment):

tests/integrations/redis/asyncio/test_redis_asyncio.py

@@ -28,7 +28,7 @@ async def test_async_basic(sentry_init, capture_events):
             "db.operation": "GET",
             "redis.key": "foobar",
             "redis.command": "GET",
-            "redis.is_cluster": False,
+            "redis.is_cluster": "False",
         },
         "timestamp": crumb["timestamp"],
         "type": "redis",
@@ -80,8 +80,8 @@ async def test_async_redis_pipeline(
         }
     )
     assert span["tags"] == {
-        "redis.transaction": is_transaction,
-        "redis.is_cluster": False,
+        "redis.transaction": str(is_transaction),
+        "redis.is_cluster": "False",
     }
 
 

tests/integrations/redis/cluster/test_redis_cluster.py

@@ -46,7 +46,7 @@ def test_rediscluster_breadcrumb(sentry_init, capture_events):
             "db.operation": "GET",
             "redis.key": "foobar",
             "redis.command": "GET",
-            "redis.is_cluster": True,
+            "redis.is_cluster": "True",
         },
         "timestamp": crumb["timestamp"],
         "type": "redis",
@@ -94,7 +94,7 @@ def test_rediscluster_basic(sentry_init, capture_events, send_default_pii, descr
     assert span["tags"] == {
         "db.operation": "SET",
         "redis.command": "SET",
-        "redis.is_cluster": True,
+        "redis.is_cluster": "True",
         "redis.key": "bar",
     }
 
@@ -141,8 +141,8 @@ def test_rediscluster_pipeline(
         }
     )
     assert span["tags"] == {
-        "redis.transaction": False,  # For Cluster, this is always False
-        "redis.is_cluster": True,
+        "redis.transaction": "False",  # For Cluster, this is always False
+        "redis.is_cluster": "True",
     }
 
 

tests/integrations/redis/cluster_asyncio/test_redis_cluster_asyncio.py

@@ -53,7 +53,7 @@ async def test_async_breadcrumb(sentry_init, capture_events):
                 "db.operation": "GET",
                 "redis.key": "foobar",
                 "redis.command": "GET",
-                "redis.is_cluster": True,
+                "redis.is_cluster": "True",
             }
         ),
         "timestamp": crumb["timestamp"],
@@ -94,7 +94,7 @@ async def test_async_basic(sentry_init, capture_events, send_default_pii, descri
         }
     )
     assert span["tags"] == {
-        "redis.is_cluster": True,
+        "redis.is_cluster": "True",
         "db.operation": "SET",
         "redis.command": "SET",
         "redis.key": "bar",
@@ -144,8 +144,8 @@ async def test_async_redis_pipeline(
         }
     )
     assert span["tags"] == {
-        "redis.transaction": False,
-        "redis.is_cluster": True,
+        "redis.transaction": "False",
+        "redis.is_cluster": "True",
     }
 
 

tests/integrations/redis/test_redis.py

@@ -34,7 +34,7 @@ def test_basic(sentry_init, capture_events):
         "data": {
             "redis.key": "foobar",
             "redis.command": "GET",
-            "redis.is_cluster": False,
+            "redis.is_cluster": "False",
             "db.operation": "GET",
         },
         "timestamp": crumb["timestamp"],
@@ -77,8 +77,8 @@ def test_redis_pipeline(
         "first_ten": expected_first_ten,
     }
     assert span["tags"] == {
-        "redis.transaction": is_transaction,
-        "redis.is_cluster": False,
+        "redis.transaction": str(is_transaction),
+        "redis.is_cluster": "False",
     }
 
 
@@ -227,7 +227,7 @@ def test_breadcrumbs(sentry_init, capture_events):
         "category": "redis",
         "data": {
             "db.operation": "SET",
-            "redis.is_cluster": False,
+            "redis.is_cluster": "False",
             "redis.command": "SET",
             "redis.key": "somekey1",
         },
@@ -239,7 +239,7 @@ def test_breadcrumbs(sentry_init, capture_events):
         "category": "redis",
         "data": {
             "db.operation": "SET",
-            "redis.is_cluster": False,
+            "redis.is_cluster": "False",
             "redis.command": "SET",
             "redis.key": "somekey2",
         },