Change Lambda timeout warning message (#4671)

The timeout in the AWS Lambda (and GCP, by extension) timeout warning is
wrong, remove it and slightly rephrase.

This is on `potel-base` since it breaks grouping. (Even just removing
the number from the original message, without modifying it further,
causes regrouping. Since that's the case I took the liberty to update
the message a bit more.)

Fixes #4629

Author: sentrivana

MIGRATION_GUIDE.md

@@ -58,6 +58,8 @@ Looking to upgrade from Sentry SDK 2.x to 3.x? Here's a comprehensive list of wh
 - `enable_logs` and `before_send_log` are now regular SDK options. Their original versions under `_experiments` have been removed.
 
 #### Integrations
+
+- AWS Lambda, GCP: The message of the warning the SDK optionally emits if a function is about to time out has changed.
 - Redis: In Redis pipeline spans there is no `span["data"]["redis.commands"]` that contains a dict `{"count": 3, "first_ten": ["cmd1", "cmd2", ...]}` but instead `span["data"]["redis.commands.count"]` (containing `3`) and `span["data"]["redis.commands.first_ten"]` (containing `["cmd1", "cmd2", ...]`).
 - clickhouse-driver: The query is now available under the `db.query.text` span attribute (only if `send_default_pii` is `True`).
 - Logging: By default, the SDK won't capture Sentry issues anymore when calling `logging.error()`, `logging.critical()` or `logging.exception()`. If you want to preserve the old behavior use `sentry_sdk.init(integrations=[LoggingIntegration(event_level="ERROR")])`.

sentry_sdk/utils.py

@@ -1424,11 +1424,7 @@ def run(self) -> None:
             integer_configured_timeout = integer_configured_timeout + 1
 
         # Raising Exception after timeout duration is reached
-        raise ServerlessTimeoutWarning(
-            "WARNING : Function is expected to get timed out. Configured timeout duration = {} seconds.".format(
-                integer_configured_timeout
-            )
-        )
+        raise ServerlessTimeoutWarning("WARNING: Function is about to time out.")
 
 
 def to_base64(original: str) -> Optional[str]:

tests/integrations/aws_lambda/test_aws_lambda.py

@@ -216,9 +216,7 @@ def test_timeout_error(lambda_client, test_environment):
     (exception,) = error_event["exception"]["values"]
     assert not exception["mechanism"]["handled"]
     assert exception["type"] == "ServerlessTimeoutWarning"
-    assert exception["value"].startswith(
-        "WARNING : Function is expected to get timed out. Configured timeout duration ="
-    )
+    assert exception["value"] == "WARNING: Function is about to time out."
     assert exception["mechanism"]["type"] == "threading"
 
 

tests/integrations/gcp/test_gcp.py

@@ -212,10 +212,7 @@ def cloud_function(functionhandler, event):
     (exception,) = envelope_items[0]["exception"]["values"]
 
     assert exception["type"] == "ServerlessTimeoutWarning"
-    assert (
-        exception["value"]
-        == "WARNING : Function is expected to get timed out. Configured timeout duration = 3 seconds."
-    )
+    assert exception["value"] == "WARNING: Function is about to time out."
     assert exception["mechanism"]["type"] == "threading"
     assert not exception["mechanism"]["handled"]