Skip to content

Commit efaa55f

Browse files
Apply suggestions from code review
Co-authored-by: Daniel Szoke <[email protected]>
1 parent 65cc78c commit efaa55f

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

scripts/populate_tox/README.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -102,11 +102,10 @@ you can say:
102102
1. Add the minimum supported version of the framework/library to `_MIN_VERSIONS`
103103
in `integrations/__init__.py`. This should be the lowest version of the
104104
framework that we can guarantee works with the SDK. If you've just added the
105-
integration, it's fine to set this to the latest version of the framework
105+
integration, you should generally set this to the latest version of the framework
106106
at the time.
107107
2. Add the integration and any constraints to `TEST_SUITE_CONFIG`. See the
108-
"Defining constraints" section for the format (or copy-paste one
109-
of the existing entries).
108+
"Defining constraints" section for the format.
110109
3. Add the integration to one of the groups in the `GROUPS` dictionary in
111110
`scripts/split_tox_gh_actions/split_tox_gh_actions.py`.
112111
4. Add the `TESTPATH` for the test suite in `tox.jinja`'s `setenv` section.

0 commit comments

Comments
 (0)