Count outcomes only for root-spans

Author: antonpirker

sentry_sdk/integrations/opentelemetry/potel_span_processor.py

@@ -59,11 +59,12 @@ def on_end(self, span):
         if is_sentry_span(span):
             return
 
-        if span.parent and not span.parent.is_remote:
-            self._children_spans[span.parent.span_id].append(span)
-        else:
+        is_root_span = not (span.parent and not span.parent.is_remote)
+        if is_root_span:
             # if have a root span ending, we build a transaction and send it
             self._flush_root_span(span)
+        else:
+            self._children_spans[span.parent.span_id].append(span)
 
     # TODO-neel-potel not sure we need a clear like JS
     def shutdown(self):

sentry_sdk/integrations/opentelemetry/sampler.py

@@ -54,17 +54,19 @@ def dropped_result(span_context, attributes, sample_rate=None):
     if sample_rate:
         trace_state = trace_state.add(TRACESTATE_SAMPLE_RATE_KEY, str(sample_rate))
 
-    # Tell Sentry why we dropped the transaction/span
-    client = sentry_sdk.get_client()
-    if client.monitor and client.monitor.downsample_factor > 0:
-        reason = "backpressure"
-    else:
-        reason = "sample_rate"
+    is_root_span = not (span_context.is_valid and not span_context.is_remote)
+    if is_root_span:
+        # Tell Sentry why we dropped the transaction/root-span
+        client = sentry_sdk.get_client()
+        if client.monitor and client.monitor.downsample_factor > 0:
+            reason = "backpressure"
+        else:
+            reason = "sample_rate"
 
-    client.transport.record_lost_event(reason, data_category="transaction")
+        client.transport.record_lost_event(reason, data_category="transaction")
 
-    # Only one span (the transaction itself) is discarded, since we did not record any spans here.
-    client.transport.record_lost_event(reason, data_category="span")
+        # Only one span (the transaction itself) is discarded, since we did not record any spans here.
+        client.transport.record_lost_event(reason, data_category="span")
 
     return SamplingResult(
         Decision.DROP,

tests/test_monitor.py

@@ -56,13 +56,15 @@ def test_monitor_unhealthy(sentry_init):
 
 
 def test_transaction_uses_downsampled_rate(
-    sentry_init, capture_record_lost_event_calls, monkeypatch
+    sentry_init, capture_envelopes, capture_record_lost_event_calls, monkeypatch
 ):
     sentry_init(
         traces_sample_rate=1.0,
         transport=UnhealthyTestTransport(),
     )
 
+    envelopes = capture_envelopes()
+
     record_lost_event_calls = capture_record_lost_event_calls()
 
     monitor = sentry_sdk.get_client().monitor
@@ -77,15 +79,32 @@ def test_transaction_uses_downsampled_rate(
     assert monitor.downsample_factor == 1
 
     with sentry_sdk.start_transaction(name="foobar") as transaction:
+        with sentry_sdk.start_span(name="foospan"):
+            with sentry_sdk.start_span(name="foospan2"):
+                with sentry_sdk.start_span(name="foospan3"):
+                    ...
+
         assert transaction.sampled is False
         assert (
             transaction.sample_rate == 0.5
         )  # TODO: this fails until we put the sample_rate in the POTelSpan
 
+    assert len(envelopes) == 0
+
     assert Counter(record_lost_event_calls) == Counter(
         [
-            ("backpressure", "transaction", None, 1),
-            ("backpressure", "span", None, 1),
+            (
+                "backpressure", 
+                "transaction", 
+                None, 
+                1, 
+            ),
+            (
+                "backpressure",
+                "span",
+                None,
+                1,
+            ),  # Only one span (the transaction itself) is counted, since we did not record any spans in the first place.
         ]
     )