Skip to content

Commit f51b4f0

Browse files
also add new test
1 parent 3112892 commit f51b4f0

File tree

1 file changed

+25
-5
lines changed

1 file changed

+25
-5
lines changed

tests/integrations/threading/test_threading.py

Lines changed: 25 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -278,10 +278,17 @@ def do_some_work(number):
278278
)
279279

280280

281-
def test_spans_from_threadpool(sentry_init, capture_events, render_span_tree):
281+
@pytest.mark.parametrize(
282+
"propagate_scope",
283+
(True, False),
284+
ids=["propagate_scope=True", "propagate_scope=False"],
285+
)
286+
def test_spans_from_threadpool(
287+
sentry_init, capture_events, render_span_tree, propagate_scope
288+
):
282289
sentry_init(
283290
traces_sample_rate=1.0,
284-
integrations=[ThreadingIntegration()],
291+
integrations=[ThreadingIntegration(propagate_scope=propagate_scope)],
285292
)
286293
events = capture_events()
287294

@@ -302,8 +309,9 @@ def do_some_work(number):
302309

303310
(event,) = events
304311

305-
assert render_span_tree(event) == dedent(
306-
"""\
312+
if propagate_scope:
313+
assert render_span_tree(event) == dedent(
314+
"""\
307315
- op="outer-trx": description=null
308316
- op="outer-submit-0": description="Thread: main"
309317
- op="inner-run-0": description="Thread: child-0"
@@ -316,4 +324,16 @@ def do_some_work(number):
316324
- op="outer-submit-4": description="Thread: main"
317325
- op="inner-run-4": description="Thread: child-4"\
318326
"""
319-
)
327+
)
328+
329+
elif not propagate_scope:
330+
assert render_span_tree(event) == dedent(
331+
"""\
332+
- op="outer-trx": description=null
333+
- op="outer-submit-0": description="Thread: main"
334+
- op="outer-submit-1": description="Thread: main"
335+
- op="outer-submit-2": description="Thread: main"
336+
- op="outer-submit-3": description="Thread: main"
337+
- op="outer-submit-4": description="Thread: main"\
338+
"""
339+
)

0 commit comments

Comments
 (0)