add source too

Author: sentrivana

sentry_sdk/integrations/opentelemetry/sampler.py

@@ -138,6 +138,7 @@ def should_sample(
                 "transaction_context": {
                     "name": name,
                     "op": attributes.get(SentrySpanAttribute.OP),
+                    "source": attributes.get(SentrySpanAttribute.SOURCE),
                 },
                 "parent_sampled": get_parent_sampled(parent_span_context, trace_id),
             }

sentry_sdk/tracing.py

@@ -1250,6 +1250,7 @@ def __init__(
                 # Prepopulate some attrs so that they're accessible in traces_sampler
                 attributes = attributes or {}
                 attributes[SentrySpanAttribute.OP] = op
+                attributes[SentrySpanAttribute.SOURCE] = source
                 if sampled is not None:
                     attributes[SentrySpanAttribute.CUSTOM_SAMPLED] = sampled
 
@@ -1260,7 +1261,6 @@ def __init__(
                 self.origin = origin or DEFAULT_SPAN_ORIGIN
                 self.description = description
                 self.name = span_name
-                self.source = source
 
                 if status is not None:
                     self.set_status(status)

tests/integrations/asgi/test_asgi.py

@@ -721,3 +721,20 @@ async def test_custom_transaction_name(
     assert transaction_event["type"] == "transaction"
     assert transaction_event["transaction"] == "foobar"
     assert transaction_event["transaction_info"] == {"source": "custom"}
+
+
+@pytest.mark.asyncio
+async def test_asgi_scope_in_traces_sampler(sentry_init, asgi3_app):
+    def dummy_traces_sampler(sampling_context):
+        assert sampling_context["asgi_scope.path"] == "/test"
+        assert sampling_context["asgi_scope.scheme"] == "http"
+
+    sentry_init(
+        traces_sampler=dummy_traces_sampler,
+        traces_sample_rate=1.0,
+    )
+
+    app = SentryAsgiMiddleware(asgi3_app)
+
+    async with TestClient(app) as client:
+        await client.get("/test")