Skip to content

Commit fe3cdda

Browse files
committed
Fix data in clickhouse-driver integration
1 parent 74cb7db commit fe3cdda

File tree

1 file changed

+12
-5
lines changed

1 file changed

+12
-5
lines changed

sentry_sdk/integrations/clickhouse_driver.py

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ def _inner(*args: P.args, **kwargs: P.kwargs) -> T:
9191

9292
_set_db_data(span, connection)
9393

94-
span.set_data("query", query)
94+
span.set_data("db.query.text", query)
9595

9696
if query_id:
9797
span.set_data("db.query_id", query_id)
@@ -118,9 +118,16 @@ def _inner_end(*args: P.args, **kwargs: P.kwargs) -> T:
118118
span.set_data("db.result", res)
119119

120120
with capture_internal_exceptions():
121-
span.scope.add_breadcrumb(
122-
message=span._data.pop("query"), category="query", data=span._data
123-
)
121+
query = span._get_attribute("db.query.text")
122+
data = {}
123+
for attr in ("db.query_id", "db.params", "db.result"):
124+
if span._get_attribute(attr):
125+
data[attr] = span._get_attribute(attr)
126+
127+
if query:
128+
sentry_sdk.add_breadcrumb(
129+
message=query, category="query", data=data
130+
)
124131

125132
span.finish()
126133

@@ -139,7 +146,7 @@ def _inner_send_data(*args: P.args, **kwargs: P.kwargs) -> T:
139146
_set_db_data(span, instance.connection)
140147

141148
if should_send_default_pii():
142-
db_params = span._data.get("db.params", [])
149+
db_params = span._get_attribute("db.params") or []
143150
db_params.extend(data)
144151
span.set_data("db.params", db_params)
145152

0 commit comments

Comments
 (0)