Skip to content

Fix arq tests in POTel #3875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 18, 2024
Merged

Fix arq tests in POTel #3875

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f0b8eb6
Fix arq tests
antonpirker Dec 17, 2024
dc9e4a3
Do not access lower level otel_span from integration
antonpirker Dec 17, 2024
77338bb
Some explaination
antonpirker Dec 17, 2024
ad035d1
Forgot unset
antonpirker Dec 17, 2024
09faed0
Added tests for status property
antonpirker Dec 17, 2024
a981e0b
Remove status setter warning
antonpirker Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion sentry_sdk/integrations/arq.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import sys

from opentelemetry.trace.status import StatusCode

import sentry_sdk
from sentry_sdk.consts import OP, SPANSTATUS
from sentry_sdk.integrations import DidNotEnable, Integration
Expand Down Expand Up @@ -116,7 +118,10 @@ async def _sentry_run_job(self, job_id, score):
origin=ArqIntegration.origin,
) as span:
return_value = await old_run_job(self, job_id, score)
span.set_status(SPANSTATUS.OK)

if span.status is None:
span.set_status(SPANSTATUS.OK)

return return_value

Worker.run_job = _sentry_run_job
Expand Down
16 changes: 16 additions & 0 deletions sentry_sdk/tracing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1583,6 +1583,22 @@ def set_attribute(self, key, value):

self._otel_span.set_attribute(key, _serialize_span_attribute(value))

@property
def status(self):
# type: () -> Optional[str]
if not hasattr(self._otel_span, "status"):
return None

if self._otel_span.status.status_code == StatusCode.OK:
return SPANSTATUS.OK
else:
return SPANSTATUS.UNKNOWN_ERROR

@status.setter
def status(self, value):
# type: (Optional[Any]) -> None
raise NotImplementedError("Use set_status instead")

def set_status(self, status):
# type: (str) -> None
if status == SPANSTATUS.OK:
Expand Down
Loading