ref(tracing): Move `TRANSACTION_SOURCE_*` constants to `Enum` #3889

mgaligniana · 2024-12-22T03:25:38Z

codecov · 2024-12-22T03:30:49Z

Codecov Report

Attention: Patch coverage is 87.80488% with 5 lines in your changes missing coverage. Please review.

Project coverage is 79.55%. Comparing base (eeedd11) to head (89160fc).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
sentry_sdk/integrations/fastapi.py	50.00%	1 Missing ⚠️
sentry_sdk/integrations/gcp.py	0.00%	1 Missing ⚠️
sentry_sdk/integrations/litestar.py	50.00%	1 Missing ⚠️
sentry_sdk/integrations/starlette.py	66.66%	1 Missing ⚠️
sentry_sdk/integrations/starlite.py	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3889      +/-   ##
==========================================
+ Coverage   79.53%   79.55%   +0.02%     
==========================================
  Files         140      140              
  Lines       15517    15521       +4     
  Branches     2630     2631       +1     
==========================================
+ Hits        12341    12348       +7     
+ Misses       2340     2338       -2     
+ Partials      836      835       -1

Files with missing lines	Coverage Δ
sentry_sdk/integrations/aiohttp.py	`81.25% <ø> (ø)`
sentry_sdk/integrations/arq.py	`89.84% <100.00%> (ø)`
sentry_sdk/integrations/asgi.py	`85.61% <100.00%> (ø)`
sentry_sdk/integrations/aws_lambda.py	`30.91% <100.00%> (ø)`
sentry_sdk/integrations/celery/__init__.py	`86.55% <100.00%> (ø)`
sentry_sdk/integrations/chalice.py	`89.18% <100.00%> (ø)`
sentry_sdk/integrations/django/__init__.py	`81.48% <100.00%> (ø)`
sentry_sdk/integrations/grpc/aio/server.py	`86.44% <100.00%> (ø)`
sentry_sdk/integrations/grpc/server.py	`76.31% <100.00%> (ø)`
sentry_sdk/integrations/huey.py	`16.66% <ø> (ø)`
... and 13 more

... and 3 files with indirect coverage changes

mgaligniana · 2024-12-22T04:54:05Z

Linter is failing because of:

Should I fix them in a different commit?

antonpirker

nice! thanks for the cleanup

antonpirker · 2024-12-23T09:01:28Z

Linter is failing because of:

Should I fix them in a different commit?

no, this is because of a new release of mypy. I will fix this.

antonpirker · 2024-12-23T09:46:18Z

This breaks a lot of tests, because the full enum ends up in the envelope that is sent to Sentry and not the .value of the enum. Can you please fix this?

antonpirker

Please fix the tests, by making sure the .value of the enum (the string) ends up in the envelop json payload that is sent to Sentry.

mgaligniana · 2024-12-23T14:01:16Z

Thank you @antonpirker! Now linter and tests passing! 💪

Fixes getsentryGH-2696

mgaligniana · 2025-02-21T12:31:07Z

Hi Anton! Just curious why did we have to delete the .value again. Let me know if there is something I can help

antonpirker · 2025-02-24T07:52:40Z

I just made it so one does not have to always use the .value, so the enum is easier to use and error due to missing .value are not happening. otherwise it is a really cool change and I will merge it today

antonpirker

This is now ready to be merged!

mgaligniana · 2025-02-24T11:54:04Z

Thank you @antonpirker !!

mgaligniana · 2025-02-24T11:55:22Z

sentry_sdk/tracing.py

+    def __str__(self):
+        return self.value


I didn't see this! Thanks for the explanation!

See getsentry/sentry-python#3889

mgaligniana marked this pull request as draft December 22, 2024 03:28

mgaligniana force-pushed the GH-2696-transaction-source-enum branch 2 times, most recently from f4bb234 to ef97faa Compare December 22, 2024 04:51

mgaligniana marked this pull request as ready for review December 22, 2024 04:54

antonpirker approved these changes Dec 23, 2024

View reviewed changes

antonpirker enabled auto-merge (squash) December 23, 2024 09:02

antonpirker suggested changes Dec 23, 2024

View reviewed changes

auto-merge was automatically disabled December 23, 2024 13:37
Head branch was pushed to by a user without write access

mgaligniana force-pushed the GH-2696-transaction-source-enum branch 4 times, most recently from b016caf to 79f20d7 Compare December 23, 2024 13:51

mgaligniana requested a review from antonpirker December 23, 2024 14:01

mgaligniana force-pushed the GH-2696-transaction-source-enum branch from 79f20d7 to e135bbc Compare January 14, 2025 13:26

ref(tracing): Move TRANSACTION_SOURCE_* constants to Enum

6609d89

Fixes getsentryGH-2696

mgaligniana force-pushed the GH-2696-transaction-source-enum branch from e135bbc to 6609d89 Compare January 15, 2025 12:01

Merge branch 'master' into getsentryGH-2696-transaction-source-enum

28cef3d

antonpirker added the Trigger: tests using secrets label Feb 20, 2025

Improvements to enum

90358dd

github-actions bot removed the Trigger: tests using secrets label Feb 21, 2025

Formatting

2a3f7a8

antonpirker added the Trigger: tests using secrets label Feb 21, 2025

Merge branch 'master' into getsentryGH-2696-transaction-source-enum

7233d5b

github-actions bot removed the Trigger: tests using secrets label Feb 21, 2025

antonpirker added 5 commits February 21, 2025 16:21

Fix clickhouse in our test suite

bc4de2d

The status output should be in the action.

0f0e46b

New version is fixed (hopefully)

4a8b5a9

bump version

09553e6

Merge branch 'antonpirker/fix-clickhouse' into pr/mgaligniana/3889

808bbb4

antonpirker added the Trigger: tests using secrets label Feb 21, 2025

linting

954a102

github-actions bot removed the Trigger: tests using secrets label Feb 21, 2025

antonpirker added the Trigger: tests using secrets label Feb 21, 2025

Merge branch 'master' into getsentryGH-2696-transaction-source-enum

6d83019

github-actions bot removed the Trigger: tests using secrets label Feb 24, 2025

antonpirker added the Trigger: tests using secrets label Feb 24, 2025

Merge branch 'master' into getsentryGH-2696-transaction-source-enum

89160fc

github-actions bot removed the Trigger: tests using secrets label Feb 24, 2025

antonpirker added the Trigger: tests using secrets label Feb 24, 2025

antonpirker enabled auto-merge (squash) February 24, 2025 09:25

antonpirker approved these changes Feb 24, 2025

View reviewed changes

antonpirker merged commit 189e4a9 into getsentry:master Feb 24, 2025
143 of 145 checks passed

mgaligniana commented Feb 24, 2025

View reviewed changes

ijustbsd mentioned this pull request Apr 23, 2025

fix: sentry-sdk ^2.23 support smagafurov/fastapi-jsonrpc#81

Merged

scottbarnes added a commit to scottbarnes/openlibrary that referenced this pull request Aug 26, 2025

Fix Sentry imports

e32e972

See getsentry/sentry-python#3889

ref(tracing): Move TRANSACTION_SOURCE_* constants to Enum #3889

ref(tracing): Move TRANSACTION_SOURCE_* constants to Enum #3889

Uh oh!

Conversation

mgaligniana commented Dec 22, 2024

Uh oh!

codecov bot commented Dec 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mgaligniana commented Dec 22, 2024

Uh oh!

antonpirker left a comment

Choose a reason for hiding this comment

Uh oh!

antonpirker commented Dec 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

antonpirker commented Dec 23, 2024

Uh oh!

antonpirker left a comment

Choose a reason for hiding this comment

Uh oh!

mgaligniana commented Dec 23, 2024

Uh oh!

mgaligniana commented Feb 21, 2025

Uh oh!

antonpirker commented Feb 24, 2025

Uh oh!

antonpirker left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mgaligniana commented Feb 24, 2025

Uh oh!

mgaligniana Feb 24, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ref(tracing): Move `TRANSACTION_SOURCE_*` constants to `Enum` #3889

ref(tracing): Move `TRANSACTION_SOURCE_*` constants to `Enum` #3889

codecov bot commented Dec 22, 2024 •

edited

Loading

antonpirker commented Dec 23, 2024 •

edited

Loading