[4] Move the Flags group over to the tox gen script #3974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szokeasaurusrex
approved these changes
Jan 31, 2025
Member
szokeasaurusrex
left a comment
szokeasaurusrex
left a comment
There was a problem hiding this comment.
Looks good, but see comment
| # integration tests there. | ||
|
|
||
| # ~~~ Flags ~~~ | ||
| launchdarkly-v9.8.1: launchdarkly-server-sdk==9.8.1 |
Member
There was a problem hiding this comment.
Shouldn't the script pull 9.8.0 instead of 9.8.1?
Contributor
Author
There was a problem hiding this comment.
It only considers the highest micro version of each release
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #3974 +/- ##
==========================================
+ Coverage 80.32% 80.33% +0.01%
==========================================
Files 140 140
Lines 15510 15510
Branches 2628 2628
==========================================
+ Hits 12458 12460 +2
+ Misses 2209 2208 -1
+ Partials 843 842 -1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openfeature,launchdarkly,statsig, andunleashfrom the tox templatepopulate_tox.pypopulate_tox.pyto fill in entries for themsplit_gh_tox_actions.pyto generate the CI yaml files so that they correspond to the newtox.iniNote that this effectively eliminates the
-latesttests for the Flags group. The script doesn't generate any-latesttests since it always makes sure to add a pinned entry for the latest version. So in case all of the integrations in a single group are using the script, the whole-latesttest category is removed.