Skip to content

Conversation

@szokeasaurusrex
Copy link
Member

We don't use the client parameter in the Scope's constructor, perhaps we can remove it and simplify the API. It is still possible to set the client with Scope.set_client.

BREAKING CHANGE: sentry_sdk.Scope no longer has a client parameter.


Thank you for contributing to sentry-python! Please add tests to validate your changes, and lint your code using tox -e linters.

Running the test suite on your PR might require maintainer approval.

We don't use the `client` parameter in the `Scope`'s constructor, perhaps we can remove it and simplify the API. It is still possible to set the client with `Scope.set_client`.

BREAKING CHANGE: `sentry_sdk.Scope` no longer has a `client` parameter.
@szokeasaurusrex szokeasaurusrex requested a review from a team as a code owner June 5, 2025 14:37
@szokeasaurusrex szokeasaurusrex requested review from antonpirker and sentrivana and removed request for a team June 5, 2025 14:37
Copy link
Member Author

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a small thing I noticed, feel free to close the PR if y'all think it is a bad idea

@codecov
Copy link

codecov bot commented Jun 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.79%. Comparing base (cfbb8db) to head (39f141b).
Report is 2 commits behind head on potel-base.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@              Coverage Diff               @@
##           potel-base    #4449      +/-   ##
==============================================
- Coverage       84.80%   84.79%   -0.02%     
==============================================
  Files             144      144              
  Lines           14725    14728       +3     
  Branches         2343     2343              
==============================================
  Hits            12488    12488              
  Misses           1523     1523              
- Partials          714      717       +3     
Files with missing lines Coverage Δ
sentry_sdk/scope.py 82.16% <100.00%> (-0.06%) ⬇️

... and 3 files with indirect coverage changes

@szokeasaurusrex szokeasaurusrex merged commit f5fb6e7 into potel-base Jun 5, 2025
124 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/remove-client-scope-param branch June 5, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants