Skip to content

test(loguru): Remove hardcoded line number in test_just_log #4552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 8, 2025
Merged

test(loguru): Remove hardcoded line number in test_just_log #4552

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b1340fb
test(loguru): Remove hardcoded line number in test_just_log
srothh Jul 7, 2025
98422f9
test(loguru): Use regex pattern instead of inspection
srothh Jul 7, 2025
7335fdc
fix(test): Loguru log test checks full regex pattern match
srothh Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions tests/integrations/loguru/test_loguru.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
from unittest.mock import MagicMock, patch
import re

import pytest
from loguru import logger
Expand Down Expand Up @@ -56,10 +57,10 @@ def test_just_log(

getattr(logger, level.name.lower())("test")

formatted_message = (
" | "
+ "{:9}".format(level.name.upper())
+ "| tests.integrations.loguru.test_loguru:test_just_log:57 - test"
expected_pattern = (
r" \| "
+ r"{:9}".format(level.name.upper())
+ r"\| tests\.integrations\.loguru\.test_loguru:test_just_log:\d+ - test"
)

if not created_event:
Expand All @@ -72,7 +73,8 @@ def test_just_log(
(breadcrumb,) = breadcrumbs
assert breadcrumb["level"] == expected_sentry_level
assert breadcrumb["category"] == "tests.integrations.loguru.test_loguru"
assert breadcrumb["message"][23:] == formatted_message
# Check that the message matches the expected pattern with a line number
assert re.search(expected_pattern, breadcrumb["message"][23:])
Copy link
Member

@szokeasaurusrex szokeasaurusrex Jul 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we want to use fullmatch rather than search. With search, the assertion passes if the string contains something matching the regex, but here, we instead want to ensure that the entire string matches

else:
assert not breadcrumbs

Expand All @@ -85,7 +87,8 @@ def test_just_log(
(event,) = events
assert event["level"] == expected_sentry_level
assert event["logger"] == "tests.integrations.loguru.test_loguru"
assert event["logentry"]["message"][23:] == formatted_message
# Check that the message matches the expected pattern with a line number
assert re.search(expected_pattern, event["logentry"]["message"][23:])


def test_breadcrumb_format(sentry_init, capture_events, uninstall_integration, request):
Expand Down
Loading