From e964133813b9c6f6480c2b47991980a4896cf003 Mon Sep 17 00:00:00 2001 From: Ivana Kellyer Date: Thu, 2 Oct 2025 16:05:42 +0200 Subject: [PATCH 1/2] Do not check for sentry.release in test_logs_attributes --- tests/test_logs.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/test_logs.py b/tests/test_logs.py index 596a31922e..7d61a1fdf7 100644 --- a/tests/test_logs.py +++ b/tests/test_logs.py @@ -230,7 +230,6 @@ def test_logs_attributes(sentry_init, capture_envelopes): for k, v in attrs.items(): assert logs[0]["attributes"][k] == v assert logs[0]["attributes"]["sentry.environment"] == "production" - assert "sentry.release" in logs[0]["attributes"] assert logs[0]["attributes"]["sentry.message.parameter.my_var"] == "some value" assert logs[0]["attributes"][SPANDATA.SERVER_ADDRESS] == "test-server" assert logs[0]["attributes"]["sentry.sdk.name"].startswith("sentry.python") From 830eda423fe7fdfcc1b5cfaf2a20e0ea1ece270e Mon Sep 17 00:00:00 2001 From: Ivana Kellyer Date: Thu, 2 Oct 2025 16:08:35 +0200 Subject: [PATCH 2/2] fix: Do not assume sentry.release is set --- tests/test_logs.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/test_logs.py b/tests/test_logs.py index 7d61a1fdf7..1e252c5bfb 100644 --- a/tests/test_logs.py +++ b/tests/test_logs.py @@ -230,6 +230,8 @@ def test_logs_attributes(sentry_init, capture_envelopes): for k, v in attrs.items(): assert logs[0]["attributes"][k] == v assert logs[0]["attributes"]["sentry.environment"] == "production" + if sentry_sdk.get_client().options.get("release") is not None: + assert "sentry.release" in logs[0]["attributes"] assert logs[0]["attributes"]["sentry.message.parameter.my_var"] == "some value" assert logs[0]["attributes"][SPANDATA.SERVER_ADDRESS] == "test-server" assert logs[0]["attributes"]["sentry.sdk.name"].startswith("sentry.python")