feat(integrations): pydantic-ai integration #4906

constantinius · 2025-10-09T16:47:20Z

Description

Integration for Pydantic AI. Support for sync and async (streaming and non-streaming)

Issues

Closes https://linear.app/getsentry/issue/TET-1242/python-sdk-pydantic-ai-integration

Reminders

Please add tests to validate your changes, and lint your code using tox -e linters.
Add GH Issue ID & Linear ID (if applicable)
PR title should use conventional commit style (feat:, fix:, ref:, meta:)
For external contributors: CONTRIBUTING.md, Sentry SDK development docs, Discord community

linear · 2025-10-09T16:47:23Z

TET-1242 Python-SDK: Pydantic AI integration

sentrivana · 2025-10-10T11:18:45Z

Hey, added a commit to run the new test suite in ci c7e7ec2 -- the script updated the test matrix for other test suites too and some of them are now failing; I'll fix that on master and then we can rebase.

### Description Updating tox + reorg the AI group alphabetically. New openai release doesn't work on 3.8, explicitly testing on 3.9+ from there Doing this now to unblock #4906 (comment) #### Issues  #### Reminders - Please add tests to validate your changes, and lint your code using `tox -e linters`. - Add GH Issue ID _&_ Linear ID (if applicable) - PR title should use [conventional commit](https://develop.sentry.dev/engineering-practices/commit-messages/#type) style (`feat:`, `fix:`, `ref:`, `meta:`) - For external contributors: [CONTRIBUTING.md](https://github.com/getsentry/sentry-python/blob/master/CONTRIBUTING.md), [Sentry SDK development docs](https://develop.sentry.dev/sdk/), [Discord community](https://discord.gg/Ww9hbqr)

sentrivana · 2025-10-10T12:04:26Z

Unrelated ci failures fixed.

Do we have test apps/scripts for this? If so would be awesome if you could add them to https://github.com/getsentry/testing-sentry-python like Vjeran did for google-genai in getsentry/testing-sentry-python#1

constantinius · 2025-10-10T12:45:58Z

@sentrivana I've pushed all tests I have here

alexander-alderman-webb

Some initial comments since I am not sure I'll get to reviewing everything in detail. There should be reviews from other SDK members coming.

sentry_sdk/integrations/pydantic_ai/spans/invoke_agent.py

sentry_sdk/integrations/pydantic_ai/patches/agent_run.py

sentry_sdk/integrations/pydantic_ai/utils.py

sentrivana

Had a first look and left some comments. Some general feedback:

There's a lot of imports in functions, I've pointed out some but not all. Please go through all non-top-level imports and if it doesn't break anything, move them to the other imports at the top of the file.
The code is not easy to follow, mostly because related parts are disconnected.
- Big part of this is that span management is scattered, e.g. a span is created in a specific function/file, then __enter__ed in a different file, and the corresponding __exit__ is someplace else still. Sometimes, we don't even know if a span is active, like in sentry_sdk/integrations/pydantic_ai/patches/agent_run.py, which shouldn't be the case:
```
                    # It could be that there is an "invoke agent" span still open
                    current_span = sentry_sdk.get_current_span()
                    if current_span is not None and current_span.timestamp is None:
                        current_span.__exit__(None, None, None)
```
It might be that most of this scattered management is simply a byproduct of how Pydantic AI/agentic flows work in general. But if we can do something to improve the flow we should.
- In general you need to do a lot of jumping around in the code to follow a specific code path. I think a big part of this is the number of new files introduced by this PR. Can we consolidate these a bit? I.e., if functions from a single file are only used in one other file, can we move them there?

This would make the code more reviewable for me, since right now I'm struggling to grasp the bigger picture. 🙂

sentry_sdk/integrations/pydantic_ai/patches/agent_run.py

sentry_sdk/integrations/pydantic_ai/patches/model_request.py

sentry_sdk/integrations/pydantic_ai/patches/tools.py

sentry_sdk/integrations/pydantic_ai/spans/ai_client.py

sentry_sdk/integrations/pydantic_ai/spans/invoke_agent.py

sentry_sdk/integrations/pydantic_ai/utils.py

sentry_sdk/integrations/pydantic_ai/spans/invoke_agent.py

Co-authored-by: Ivana Kellyer <[email protected]>

Removing the workflow spans, using better suited hook functions to patch into

codecov · 2025-10-22T15:14:34Z

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
27415	1	27414	2021

View the top 1 failed test(s) by shortest run time

tests.profiler.test_continuous_profiler::test_continuous_profiler_auto_start_and_manual_stop[non-experiment-start_profiler/stop_profiler-gevent]

Stack Traces | 0.528s run time

tests/profiler/test_continuous_profiler.py:291: in test_continuous_profiler_auto_start_and_manual_stop
    assert_single_transaction_with_profile_chunks(envelopes, thread)
tests/profiler/test_continuous_profiler.py:147: in assert_single_transaction_with_profile_chunks
    assert len(items["profile_chunk"]) > 0
E   assert 0 > 0
E    +  where 0 = len([])

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

constantinius · 2025-10-22T15:17:50Z

I significantly (I hope) simplified the and streamlined the integration. I hope it is now more readable and understandable. Also a lot of code smells (like imports in between or excessive use of __exit__) were removed. Could you please give another look @sentrivana?

cursor · 2025-10-23T09:22:39Z

Bug: Optional Dependency Import Error

The import agents statement is now unconditional and outside the try...except block in both tools.py and utils.py. If the agents package is not installed, this raises an ImportError at module load time instead of gracefully raising DidNotEnable as expected for optional dependencies.

Additional Locations (1)

sentry_sdk/integrations/openai_agents/patches/tools.py#L11-L17

cursor · 2025-10-23T09:22:40Z

Bug: Import Failure Causes `isinstance` TypeError

The isinstance check for FunctionTool can raise a TypeError. If the from agents import FunctionTool import fails, FunctionTool is set to None, which isinstance doesn't accept as a type.

Additional Locations (1)

sentry_sdk/integrations/openai_agents/patches/tools.py#L39-L40

… raised

cursor · 2025-10-23T09:27:06Z

Bug: ImportError Handling Regression

The import agents statement was moved outside its try-except block in tools.py and utils.py. If the agents package is not installed, this now raises an unhandled ImportError instead of gracefully disabling the integration or setting related classes to None.

Additional Locations (1)

sentry_sdk/integrations/openai_agents/patches/tools.py#L11-L17

…s/utils.py sentry_sdk/integrations/openai_agents/spans/execute_tool.py sentry_sdk/integrations/openai_agents/utils.py

cursor · 2025-10-23T09:32:39Z

Bug: Pydantic AI Integration Fails Without Installation

The pydantic_ai integration raises DidNotEnable at module import time when pydantic-ai isn't installed. This prevents the integration module from being imported, which breaks the SDK's integration discovery and can cause initialization failures.

constantinius added 4 commits October 9, 2025 09:38

feat(integrations): added initial Pydantic AI integration implementation

f667f4b

fix: model name lookup and message history preservation

8c26119

feat: add support for run_stream

742d77f

fix: deduping code

76a7a67

constantinius requested a review from a team October 9, 2025 16:47

constantinius added 3 commits October 10, 2025 08:36

fix(integrations): add pydantic-ai as an optional dependency

9d166ba

fix(integrations): fixing span description -> name

3337c19

feat: add include_prompts for Pydantic AI integration

bf3ce00

constantinius marked this pull request as ready for review October 10, 2025 08:58

constantinius requested a review from a team as a code owner October 10, 2025 08:58

This was referenced Oct 10, 2025

feat(python): add docs for Pydantic AI integration getsentry/sentry-docs#15177

Open

feat(onboarding): Add Pydantic AI integration steps and links getsentry/sentry#101328

Open

sentrivana added 2 commits October 10, 2025 13:09

Merge branch 'master' into constantinius/feat/integration/pydantic-ai

2290901

Add pydantic ai to ci

c7e7ec2

add pytest-asyncio

1a2cb97

sentrivana mentioned this pull request Oct 10, 2025

tests: Update tox #4913

Merged

Merge branch 'master' into constantinius/feat/integration/pydantic-ai

b9f3357

fix: mypy issues

48af290

alexander-alderman-webb requested changes Oct 13, 2025

View reviewed changes

fix: working in feedback

7263a77

sentrivana reviewed Oct 15, 2025

View reviewed changes

Update sentry_sdk/integrations/pydantic_ai/spans/invoke_agent.py

a94870e

Co-authored-by: Ivana Kellyer <[email protected]>

This comment was marked as outdated.

Sign in to view

constantinius added 2 commits October 15, 2025 16:59

fix(integrations): cleanups and working in feedback

7f335f9

fix(integrations): type checking import missing

0929e58

fix: significantly simplifying instrumentation

4b40d2d

Removing the workflow spans, using better suited hook functions to patch into

This comment was marked as outdated.

Sign in to view

constantinius requested a review from sentrivana October 22, 2025 15:17

constantinius added 3 commits October 22, 2025 18:45

feat: add support for MCP Tool calls as well

87ebafc

test: update tests to reflect recent changes

9e20ebb

fix: working in feedback, making object typechecks less brittle

b25c434

constantinius requested a review from alexander-alderman-webb October 23, 2025 09:20

fix: shuffling imports so that the DidNotEnable exception is actually…

97d6b52

… raised

ci: -m revert: wrong integration sentry_sdk/integrations/openai_agent…

0a32559

…s/utils.py sentry_sdk/integrations/openai_agents/spans/execute_tool.py sentry_sdk/integrations/openai_agents/utils.py

feat(integrations): pydantic-ai integration #4906

Are you sure you want to change the base?

feat(integrations): pydantic-ai integration #4906

Conversation

constantinius commented Oct 9, 2025

Description

Issues

Reminders

Uh oh!

linear bot commented Oct 9, 2025

Uh oh!

sentrivana commented Oct 10, 2025

Uh oh!

sentrivana commented Oct 10, 2025

Uh oh!

constantinius commented Oct 10, 2025

Uh oh!

alexander-alderman-webb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sentrivana left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

codecov bot commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 1 Tests Failed:

Uh oh!

constantinius commented Oct 22, 2025

Uh oh!

cursor bot commented Oct 23, 2025

Bug: Optional Dependency Import Error

Uh oh!

cursor bot commented Oct 23, 2025

Bug: Import Failure Causes isinstance TypeError

Uh oh!

cursor bot commented Oct 23, 2025

Bug: ImportError Handling Regression

Uh oh!

cursor bot commented Oct 23, 2025

Bug: Pydantic AI Integration Fails Without Installation

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sentrivana left a comment •

edited

Loading

codecov bot commented Oct 22, 2025 •

edited

Loading

Bug: Import Failure Causes `isinstance` TypeError