-
Notifications
You must be signed in to change notification settings - Fork 571
feat(logs): Record discarded log bytes #5144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5144 +/- ##
=======================================
Coverage 84.03% 84.04%
=======================================
Files 180 180
Lines 18223 18227 +4
Branches 3235 3236 +1
=======================================
+ Hits 15314 15318 +4
Misses 1921 1921
Partials 988 988
|
sl0thentr0py
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Report discarded log size in bytes as part of client reports, based on the specification added in getsentry/sentry-docs@5819cdd.
The reported size is based on the log format submitted to the transport. The bytes representation used to calculate the size in bytes is returned by
PayloadRef.get_bytes(). In all common code paths, the representation is a compactutf-8encoding of the log.Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)