Skip to content

Conversation

@constantinius
Copy link
Contributor

@constantinius constantinius requested a review from a team as a code owner November 26, 2025 14:37
@linear
Copy link

linear bot commented Nov 26, 2025

@constantinius constantinius requested a review from a team November 26, 2025 14:37
@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

❌ Patch coverage is 89.65517% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.99%. Comparing base (7b7ea33) to head (6a1d6b3).
⚠️ Report is 10 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...y_sdk/integrations/openai_agents/patches/models.py 86.66% 0 Missing and 2 partials ⚠️
...k/integrations/openai_agents/spans/invoke_agent.py 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5157      +/-   ##
==========================================
+ Coverage   83.97%   83.99%   +0.01%     
==========================================
  Files         180      181       +1     
  Lines       18222    18251      +29     
  Branches     3235     3239       +4     
==========================================
+ Hits        15302    15330      +28     
  Misses       1929     1929              
- Partials      991      992       +1     
Files with missing lines Coverage Δ
...ry_sdk/integrations/openai_agents/_context_vars.py 100.00% <100.00%> (ø)
..._sdk/integrations/openai_agents/spans/ai_client.py 100.00% <100.00%> (ø)
...k/integrations/openai_agents/spans/invoke_agent.py 87.50% <87.50%> (-0.38%) ⬇️
...y_sdk/integrations/openai_agents/patches/models.py 89.18% <86.66%> (-1.72%) ⬇️

... and 6 files with indirect coverage changes

model = original_get_model(agent, run_config)
original_get_response = model.get_response

# Wrap _fetch_response if it exists (for OpenAI models) to capture raw response model
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of curiosity, why do we need to capture the raw response model?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only place I found to get the response model. OpenAI Agents does not expose this, we only get the request model, but not the response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants