Skip to content

Deprecate continue_from_headers #5160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2025
Merged

Deprecate continue_from_headers #5160

merged 1 commit into from
Nov 27, 2025

Conversation

@sl0thentr0py
Copy link
Member

@sl0thentr0py sl0thentr0py commented Nov 27, 2025

Description

continue_trace should be the only recommended way of continuing upstream traces now.

@codecov
Copy link

codecov bot commented Nov 27, 2025 •
edited
Loading

❌ 14 Tests Failed:

Tests completed Failed Passed Skipped
26460 14 26446 2204
View the top 3 failed test(s) by shortest run time 
tests.integrations.stdlib.test_httplib::test_outgoing_trace_headers
Stack Traces | 0.091s run time 
.../integrations/stdlib/test_httplib.py:229: in test_outgoing_trace_headers
    assert request_headers["baggage"] == expected_outgoing_baggage
E   AssertionError: assert 'sentry-trace_id=811e67423c024e1aa526bed98ebe3d69,sentry-sample_rand=0.393948,sentry-environment=production,sentry-release=05661864ab106ea03af3e4181064b49f0f010e91,sentry-sample_rate=1.0,sentry-sampled=true' == 'sentry-trace_id=771a43a4192642f0b136d5159a501700,sentry-public_key=49d0f7386ad645858ae85020e393bef3,sentry-sample_rate=1.0,sentry-user_id=Am%C3%A9lie,sentry-sample_rand=0.132521102938283'
E     - sentry-trace_id=771a43a4192642f0b136d5159a501700,sentry-public_key=49d0f7386ad645858ae85020e393bef3,sentry-sample_rate=1.0,sentry-user_id=Am%C3%A9lie,sentry-sample_rand=0.132521102938283
E     + sentry-trace_id=811e67423c024e1aa526bed98ebe3d69,sentry-sample_rand=0.393948,sentry-environment=production,sentry-release=05661864ab106ea03af3e4181064b49f0f010e91,sentry-sample_rate=1.0,sentry-sampled=true
tests.integrations.stdlib.test_httplib::test_outgoing_trace_headers
Stack Traces | 0.093s run time 
.../integrations/stdlib/test_httplib.py:229: in test_outgoing_trace_headers
    assert request_headers["baggage"] == expected_outgoing_baggage
E   AssertionError: assert 'sentry-trace_id=495b52697c6249b1a59de622d144c0bb,sentry-sample_rand=0.455155,sentry-environment=production,sentry-release=05661864ab106ea03af3e4181064b49f0f010e91,sentry-sample_rate=1.0,sentry-sampled=true' == 'sentry-trace_id=771a43a4192642f0b136d5159a501700,sentry-public_key=49d0f7386ad645858ae85020e393bef3,sentry-sample_rate=1.0,sentry-user_id=Am%C3%A9lie,sentry-sample_rand=0.132521102938283'
E     - sentry-trace_id=771a43a4192642f0b136d5159a501700,sentry-public_key=49d0f7386ad645858ae85020e393bef3,sentry-sample_rate=1.0,sentry-user_id=Am%C3%A9lie,sentry-sample_rand=0.132521102938283
E     + sentry-trace_id=495b52697c6249b1a59de622d144c0bb,sentry-sample_rand=0.455155,sentry-environment=production,sentry-release=05661864ab106ea03af3e4181064b49f0f010e91,sentry-sample_rate=1.0,sentry-sampled=true
tests.integrations.stdlib.test_httplib::test_outgoing_trace_headers
Stack Traces | 0.094s run time 
.../integrations/stdlib/test_httplib.py:229: in test_outgoing_trace_headers
    assert request_headers["baggage"] == expected_outgoing_baggage
E   AssertionError: assert 'sentry-trace_id=0471b98f8336470e91c48ff6cd51bb42,sentry-sample_rand=0.837319,sentry-environment=production,sentry-release=05661864ab106ea03af3e4181064b49f0f010e91,sentry-sample_rate=1.0,sentry-sampled=true' == 'sentry-trace_id=771a43a4192642f0b136d5159a501700,sentry-public_key=49d0f7386ad645858ae85020e393bef3,sentry-sample_rate=1.0,sentry-user_id=Am%C3%A9lie,sentry-sample_rand=0.132521102938283'
E     
E     - sentry-trace_id=771a43a4192642f0b136d5159a501700,sentry-public_key=49d0f7386ad645858ae85020e393bef3,sentry-sample_rate=1.0,sentry-user_id=Am%C3%A9lie,sentry-sample_rand=0.132521102938283
E     + sentry-trace_id=0471b98f8336470e91c48ff6cd51bb42,sentry-sample_rand=0.837319,sentry-environment=production,sentry-release=05661864ab106ea03af3e4181064b49f0f010e91,sentry-sample_rate=1.0,sentry-sampled=true
tests.integrations.stdlib.test_httplib::test_outgoing_trace_headers
Stack Traces | 0.095s run time 
.../integrations/stdlib/test_httplib.py:229: in test_outgoing_trace_headers
    assert request_headers["baggage"] == expected_outgoing_baggage
E   AssertionError: assert 'sentry-trace_id=62bdb7567af340d488d4bf0319c7806f,sentry-sample_rand=0.113045,sentry-environment=production,sentry-release=05661864ab106ea03af3e4181064b49f0f010e91,sentry-sample_rate=1.0,sentry-sampled=true' == 'sentry-trace_id=771a43a4192642f0b136d5159a501700,sentry-public_key=49d0f7386ad645858ae85020e393bef3,sentry-sample_rate=1.0,sentry-user_id=Am%C3%A9lie,sentry-sample_rand=0.132521102938283'
E     
E     - sentry-trace_id=771a43a4192642f0b136d5159a501700,sentry-public_key=49d0f7386ad645858ae85020e393bef3,sentry-sample_rate=1.0,sentry-user_id=Am%C3%A9lie,sentry-sample_rand=0.132521102938283
E     + sentry-trace_id=62bdb7567af340d488d4bf0319c7806f,sentry-sample_rand=0.113045,sentry-environment=production,sentry-release=05661864ab106ea03af3e4181064b49f0f010e91,sentry-sample_rate=1.0,sentry-sampled=true
tests.integrations.stdlib.test_httplib::test_outgoing_trace_headers
Stack Traces | 0.099s run time 
.../integrations/stdlib/test_httplib.py:229: in test_outgoing_trace_headers
    assert request_headers["baggage"] == expected_outgoing_baggage
E   AssertionError: assert 'sentry-trace_id=adcde0d53cc3437ea61bad298d8ef02c,sentry-sample_rand=0.144245,sentry-environment=production,sentry-release=05661864ab106ea03af3e4181064b49f0f010e91,sentry-sample_rate=1.0,sentry-sampled=true' == 'sentry-trace_id=771a43a4192642f0b136d5159a501700,sentry-public_key=49d0f7386ad645858ae85020e393bef3,sentry-sample_rate=1.0,sentry-user_id=Am%C3%A9lie,sentry-sample_rand=0.132521102938283'
E     - sentry-trace_id=771a43a4192642f0b136d5159a501700,sentry-public_key=49d0f7386ad645858ae85020e393bef3,sentry-sample_rate=1.0,sentry-user_id=Am%C3%A9lie,sentry-sample_rand=0.132521102938283
E     + sentry-trace_id=adcde0d53cc3437ea61bad298d8ef02c,sentry-sample_rand=0.144245,sentry-environment=production,sentry-release=05661864ab106ea03af3e4181064b49f0f010e91,sentry-sample_rate=1.0,sentry-sampled=true
tests.integrations.stdlib.test_httplib::test_outgoing_trace_headers
Stack Traces | 0.105s run time 
.../integrations/stdlib/test_httplib.py:229: in test_outgoing_trace_headers
    assert request_headers["baggage"] == expected_outgoing_baggage
E   AssertionError: assert 'sentry-trace_id=2bd76840dcf84d83883b69630e8240b2,sentry-sample_rand=0.317275,sentry-environment=production,sentry-release=05661864ab106ea03af3e4181064b49f0f010e91,sentry-sample_rate=1.0,sentry-sampled=true' == 'sentry-trace_id=771a43a4192642f0b136d5159a501700,sentry-public_key=49d0f7386ad645858ae85020e393bef3,sentry-sample_rate=1.0,sentry-user_id=Am%C3%A9lie,sentry-sample_rand=0.132521102938283'
E     
E     - sentry-trace_id=771a43a4192642f0b136d5159a501700,sentry-public_key=49d0f7386ad645858ae85020e393bef3,sentry-sample_rate=1.0,sentry-user_id=Am%C3%A9lie,sentry-sample_rand=0.132521102938283
E     + sentry-trace_id=2bd76840dcf84d83883b69630e8240b2,sentry-sample_rand=0.317275,sentry-environment=production,sentry-release=05661864ab106ea03af3e4181064b49f0f010e91,sentry-sample_rate=1.0,sentry-sampled=true
tests.integrations.stdlib.test_httplib::test_outgoing_trace_headers
Stack Traces | 0.109s run time 
.../integrations/stdlib/test_httplib.py:229: in test_outgoing_trace_headers
    assert request_headers["baggage"] == expected_outgoing_baggage
E   AssertionError: assert 'sentry-trace_id=54bb5ef4102c4c0fba9c03e5bafc6746,sentry-sample_rand=0.505291,sentry-environment=production,sentry-release=05661864ab106ea03af3e4181064b49f0f010e91,sentry-sample_rate=1.0,sentry-sampled=true' == 'sentry-trace_id=771a43a4192642f0b136d5159a501700,sentry-public_key=49d0f7386ad645858ae85020e393bef3,sentry-sample_rate=1.0,sentry-user_id=Am%C3%A9lie,sentry-sample_rand=0.132521102938283'
E     
E     - sentry-trace_id=771a43a4192642f0b136d5159a501700,sentry-public_key=49d0f7386ad645858ae85020e393bef3,sentry-sample_rate=1.0,sentry-user_id=Am%C3%A9lie,sentry-sample_rand=0.132521102938283
E     + sentry-trace_id=54bb5ef4102c4c0fba9c03e5bafc6746,sentry-sample_rand=0.505291,sentry-environment=production,sentry-release=05661864ab106ea03af3e4181064b49f0f010e91,sentry-sample_rate=1.0,sentry-sampled=true
tests.integrations.stdlib.test_httplib::test_outgoing_trace_headers
Stack Traces | 0.109s run time 
.../integrations/stdlib/test_httplib.py:229: in test_outgoing_trace_headers
    assert request_headers["baggage"] == expected_outgoing_baggage
E   AssertionError: assert 'sentry-trace_id=363380f553c94826b50c96d31d2dc549,sentry-sample_rand=0.954557,sentry-environment=production,sentry-release=05661864ab106ea03af3e4181064b49f0f010e91,sentry-sample_rate=1.0,sentry-sampled=true' == 'sentry-trace_id=771a43a4192642f0b136d5159a501700,sentry-public_key=49d0f7386ad645858ae85020e393bef3,sentry-sample_rate=1.0,sentry-user_id=Am%C3%A9lie,sentry-sample_rand=0.132521102938283'
E     
E     - sentry-trace_id=771a43a4192642f0b136d5159a501700,sentry-public_key=49d0f7386ad645858ae85020e393bef3,sentry-sample_rate=1.0,sentry-user_id=Am%C3%A9lie,sentry-sample_rand=0.132521102938283
E     + sentry-trace_id=363380f553c94826b50c96d31d2dc549,sentry-sample_rand=0.954557,sentry-environment=production,sentry-release=05661864ab106ea03af3e4181064b49f0f010e91,sentry-sample_rate=1.0,sentry-sampled=true
tests.integrations.stdlib.test_httplib::test_outgoing_trace_headers
Stack Traces | 0.11s run time 
.../integrations/stdlib/test_httplib.py:229: in test_outgoing_trace_headers
    assert request_headers["baggage"] == expected_outgoing_baggage
E   AssertionError: assert 'sentry-trace_id=012f7cd258ba4aad9ef1c6ffc85776c7,sentry-sample_rand=0.990610,sentry-environment=production,sentry-release=05661864ab106ea03af3e4181064b49f0f010e91,sentry-sample_rate=1.0,sentry-sampled=true' == 'sentry-trace_id=771a43a4192642f0b136d5159a501700,sentry-public_key=49d0f7386ad645858ae85020e393bef3,sentry-sample_rate=1.0,sentry-user_id=Am%C3%A9lie,sentry-sample_rand=0.132521102938283'
E     
E     - sentry-trace_id=771a43a4192642f0b136d5159a501700,sentry-public_key=49d0f7386ad645858ae85020e393bef3,sentry-sample_rate=1.0,sentry-user_id=Am%C3%A9lie,sentry-sample_rand=0.132521102938283
E     + sentry-trace_id=012f7cd258ba4aad9ef1c6ffc85776c7,sentry-sample_rand=0.990610,sentry-environment=production,sentry-release=05661864ab106ea03af3e4181064b49f0f010e91,sentry-sample_rate=1.0,sentry-sampled=true
tests.integrations.stdlib.test_httplib::test_outgoing_trace_headers
Stack Traces | 0.119s run time 
.../integrations/stdlib/test_httplib.py:229: in test_outgoing_trace_headers
    assert request_headers["baggage"] == expected_outgoing_baggage
E   AssertionError: assert 'sentry-trace_id=deff41e87cc84eb39f9bf598bd504ae7,sentry-sample_rand=0.242336,sentry-environment=production,sentry-release=05661864ab106ea03af3e4181064b49f0f010e91,sentry-sample_rate=1.0,sentry-sampled=true' == 'sentry-trace_id=771a43a4192642f0b136d5159a501700,sentry-public_key=49d0f7386ad645858ae85020e393bef3,sentry-sample_rate=1.0,sentry-user_id=Am%C3%A9lie,sentry-sample_rand=0.132521102938283'
E     
E     - sentry-trace_id=771a43a4192642f0b136d5159a501700,sentry-public_key=49d0f7386ad645858ae85020e393bef3,sentry-sample_rate=1.0,sentry-user_id=Am%C3%A9lie,sentry-sample_rand=0.132521102938283
E     + sentry-trace_id=deff41e87cc84eb39f9bf598bd504ae7,sentry-sample_rand=0.242336,sentry-environment=production,sentry-release=05661864ab106ea03af3e4181064b49f0f010e91,sentry-sample_rate=1.0,sentry-sampled=true
tests.integrations.stdlib.test_httplib::test_outgoing_trace_headers
Stack Traces | 0.126s run time 
.../integrations/stdlib/test_httplib.py:229: in test_outgoing_trace_headers
    assert request_headers["baggage"] == expected_outgoing_baggage
E   AssertionError: assert 'sentry-trace_id=4b0eb23eefff4d16b6eb904679dc3d8e,sentry-sample_rand=0.752528,sentry-environment=production,sentry-release=05661864ab106ea03af3e4181064b49f0f010e91,sentry-sample_rate=1.0,sentry-sampled=true' == 'sentry-trace_id=771a43a4192642f0b136d5159a501700,sentry-public_key=49d0f7386ad645858ae85020e393bef3,sentry-sample_rate=1.0,sentry-user_id=Am%C3%A9lie,sentry-sample_rand=0.132521102938283'
E     
E     - sentry-trace_id=771a43a4192642f0b136d5159a501700,sentry-public_key=49d0f7386ad645858ae85020e393bef3,sentry-sample_rate=1.0,sentry-user_id=Am%C3%A9lie,sentry-sample_rand=0.132521102938283
E     + sentry-trace_id=4b0eb23eefff4d16b6eb904679dc3d8e,sentry-sample_rand=0.752528,sentry-environment=production,sentry-release=05661864ab106ea03af3e4181064b49f0f010e91,sentry-sample_rate=1.0,sentry-sampled=true
tests.integrations.stdlib.test_httplib::test_outgoing_trace_headers
Stack Traces | 0.129s run time 
.../integrations/stdlib/test_httplib.py:229: in test_outgoing_trace_headers
    assert request_headers["baggage"] == expected_outgoing_baggage
E   AssertionError: assert 'sentry-trace_id=8952200444484ebd95e96f7ee81f8bdc,sentry-sample_rand=0.201213,sentry-environment=production,sentry-release=05661864ab106ea03af3e4181064b49f0f010e91,sentry-sample_rate=1.0,sentry-sampled=true' == 'sentry-trace_id=771a43a4192642f0b136d5159a501700,sentry-public_key=49d0f7386ad645858ae85020e393bef3,sentry-sample_rate=1.0,sentry-user_id=Am%C3%A9lie,sentry-sample_rand=0.132521102938283'
E     
E     - sentry-trace_id=771a43a4192642f0b136d5159a501700,sentry-public_key=49d0f7386ad645858ae85020e393bef3,sentry-sample_rate=1.0,sentry-user_id=Am%C3%A9lie,sentry-sample_rand=0.132521102938283
E     + sentry-trace_id=8952200444484ebd95e96f7ee81f8bdc,sentry-sample_rand=0.201213,sentry-environment=production,sentry-release=05661864ab106ea03af3e4181064b49f0f010e91,sentry-sample_rate=1.0,sentry-sampled=true
tests.integrations.stdlib.test_httplib::test_outgoing_trace_headers
Stack Traces | 0.135s run time 
.../integrations/stdlib/test_httplib.py:229: in test_outgoing_trace_headers
    assert request_headers["baggage"] == expected_outgoing_baggage
E   AssertionError: assert 'sentry-trace_id=61f9f510f871473ebfdbf13e4e3df054,sentry-sample_rand=0.503335,sentry-environment=production,sentry-release=05661864ab106ea03af3e4181064b49f0f010e91,sentry-sample_rate=1.0,sentry-sampled=true' == 'sentry-trace_id=771a43a4192642f0b136d5159a501700,sentry-public_key=49d0f7386ad645858ae85020e393bef3,sentry-sample_rate=1.0,sentry-user_id=Am%C3%A9lie,sentry-sample_rand=0.132521102938283'
E     
E     - sentry-trace_id=771a43a4192642f0b136d5159a501700,sentry-public_key=49d0f7386ad645858ae85020e393bef3,sentry-sample_rate=1.0,sentry-user_id=Am%C3%A9lie,sentry-sample_rand=0.132521102938283
E     + sentry-trace_id=61f9f510f871473ebfdbf13e4e3df054,sentry-sample_rand=0.503335,sentry-environment=production,sentry-release=05661864ab106ea03af3e4181064b49f0f010e91,sentry-sample_rate=1.0,sentry-sampled=true
tests.integrations.stdlib.test_httplib::test_outgoing_trace_headers
Stack Traces | 0.202s run time 
.../integrations/stdlib/test_httplib.py:229: in test_outgoing_trace_headers
    assert request_headers["baggage"] == expected_outgoing_baggage
E   AssertionError: assert 'sentry-trace_id=3ea366b8fac04c6fa2b37db79eae021b,sentry-sample_rand=0.662183,sentry-environment=production,sentry-release=05661864ab106ea03af3e4181064b49f0f010e91,sentry-sample_rate=1.0,sentry-sampled=true' == 'sentry-trace_id=771a43a4192642f0b136d5159a501700,sentry-public_key=49d0f7386ad645858ae85020e393bef3,sentry-sample_rate=1.0,sentry-user_id=Am%C3%A9lie,sentry-sample_rand=0.132521102938283'
E     
E     - sentry-trace_id=771a43a4192642f0b136d5159a501700,sentry-public_key=49d0f7386ad645858ae85020e393bef3,sentry-sample_rate=1.0,sentry-user_id=Am%C3%A9lie,sentry-sample_rand=0.132521102938283
E     + sentry-trace_id=3ea366b8fac04c6fa2b37db79eae021b,sentry-sample_rand=0.662183,sentry-environment=production,sentry-release=05661864ab106ea03af3e4181064b49f0f010e91,sentry-sample_rate=1.0,sentry-sampled=true

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@sl0thentr0py sl0thentr0py force-pushed the neel/deprecate-continue branch 2 times, most recently from 3682891 to f35af52 Compare November 27, 2025 09:39
sl0thentr0py
sl0thentr0py commented Nov 27, 2025
View reviewed changes
tests/tracing/test_integration_tests.py

# will create empty mutable baggage
baggage = transaction._baggage
assert baggage
Copy link
Member Author

@sl0thentr0py sl0thentr0py Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this differs from the old implementation in that baggage is now None for this case instead of empty and mutable, but the head SDK population semantic is the same, so this is fine.

@sl0thentr0py sl0thentr0py marked this pull request as ready for review November 27, 2025 09:50
@sl0thentr0py sl0thentr0py requested a review from a team as a code owner November 27, 2025 09:50
cursor[bot]
cursor bot reviewed Nov 27, 2025
View reviewed changes
@sl0thentr0py sl0thentr0py force-pushed the neel/deprecate-continue branch from f35af52 to f246719 Compare November 27, 2025 09:58
sentrivana
sentrivana approved these changes Nov 27, 2025
View reviewed changes
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:tears-of-joy:

@sl0thentr0py sl0thentr0py merged commit b528f32 into master Nov 27, 2025
155 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/deprecate-continue branch November 27, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@sentrivana sentrivana sentrivana approved these changes

Assignees

No one assigned

Labels

Changelog: Deprecation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sl0thentr0py @sentrivana