fix(openai-agents): Store invoke_agent span on agents.RunContextWrapper
#5165
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-alderman-webb
changed the title
invoke_agent span on agents.RunContextWrapper
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using
sentry_sdk.get_current_span()is problematic with theasynciointegration. The integration forks the isolation and current scopes, sosentry_sdk.get_current_span()can return a span that does not correspond to the agent invocation.The coroutine in which the agent span is entered finishes before the agent span is finished. When the coroutine exits, its scopes are popped, and the agent invocation span is lost before it is exited. You can confirm by setting breakpoints in the
asyncioandopenai-agentsintegrations, and running the reproduction provided in #5067.See more details here #5067 (comment).
Issues
Closes #5067
Reminders
tox -e linters.feat:,fix:,ref:,meta:)