fix(session-replay): Leave captureReplay logic to the native implementation (#5243)

* fix(session-replay): Always try to record replay for hard crashes

* Adds changelog

* Improve logging

* Remove unnecessary RN logic

Author: antonis

CHANGELOG.md

@@ -18,6 +18,7 @@
 - Fixes .env file loading in Expo sourcemap uploads ([#5210](https://github.com/getsentry/sentry-react-native/pull/5210))
 - Fixes the issue with changing immutable metadata structure in the contructor of `ReactNativeClient`. This structure is getting re-created instead of being modified to ensure IP address is only inferred by Relay if `sendDefaultPii` is `true` ([#5202](https://github.com/getsentry/sentry-react-native/pull/5202))
 - Removes usage of deprecated `SafeAreaView` ([#5241](https://github.com/getsentry/sentry-react-native/pull/5241))
+- Fixes session replay recording for uncaught errors ([#5243](https://github.com/getsentry/sentry-react-native/pull/5243))
 
 ### Dependencies
 

packages/core/src/js/replay/mobilereplay.ts

@@ -137,18 +137,20 @@ export const mobileReplayIntegration = (initOptions: MobileReplayOptions = defau
       return event;
     }
 
-    const recordingReplayId = NATIVE.getCurrentReplayId();
-    if (recordingReplayId) {
-      debug.log(
-        `[Sentry] ${MOBILE_REPLAY_INTEGRATION_NAME} assign already recording replay ${recordingReplayId} for event ${event.event_id}.`,
-      );
-      return event;
-    }
-
     const replayId = await NATIVE.captureReplay(isHardCrash(event));
     if (!replayId) {
-      debug.log(`[Sentry] ${MOBILE_REPLAY_INTEGRATION_NAME} not sampled for event ${event.event_id}.`);
-      return event;
+      const recordingReplayId = NATIVE.getCurrentReplayId();
+      if (recordingReplayId) {
+        debug.log(
+          `[Sentry] ${MOBILE_REPLAY_INTEGRATION_NAME} assign already recording replay ${recordingReplayId} for event ${event.event_id}.`,
+        );
+      } else {
+        debug.log(`[Sentry] ${MOBILE_REPLAY_INTEGRATION_NAME} not sampled for event ${event.event_id}.`);
+      }
+    } else {
+      debug.log(
+        `[Sentry] ${MOBILE_REPLAY_INTEGRATION_NAME} Captured recording replay ${replayId} for event ${event.event_id}.`,
+      );
     }
 
     return event;