feat: Remove react application parameter (#427)

Author: HazAT

android/src/main/java/io/sentry/RNSentryModule.java

@@ -5,7 +5,6 @@
 import android.content.pm.PackageManager;
 import android.support.annotation.NonNull;
 
-import com.facebook.react.ReactApplication;
 import com.facebook.react.bridge.Arguments;
 import com.facebook.react.bridge.Promise;
 import com.facebook.react.bridge.ReactApplicationContext;
@@ -52,11 +51,10 @@
 public class RNSentryModule extends ReactContextBaseJavaModule {
 
     private static final Pattern mJsModuleIdPattern = Pattern.compile("(?:^|[/\\\\])(\\d+\\.js)$");
-    private static final String versionString = "0.37.1";
+    private static final String versionString = "0.35.4";
     private static final String sdkName = "sentry-react-native";
 
     private final ReactApplicationContext reactContext;
-    private final ReactApplication reactApplication;
 
     private static AndroidEventBuilderHelper androidHelper;
     private static PackageInfo packageInfo;
@@ -65,18 +63,13 @@ public class RNSentryModule extends ReactContextBaseJavaModule {
     private static ReadableMap tags;
     private static SentryClient sentryClient;
 
-    public RNSentryModule(ReactApplicationContext reactContext, ReactApplication reactApplication) {
+    public RNSentryModule(ReactApplicationContext reactContext) {
         super(reactContext);
         this.reactContext = reactContext;
-        this.reactApplication = reactApplication;
         RNSentryModule.extra = new WritableNativeMap();
         RNSentryModule.packageInfo = getPackageInfo(reactContext);
     }
 
-    public ReactApplication getReactApplication() {
-        return reactApplication;
-    }
-
     @Override
     public String getName() {
         return "RNSentry";
@@ -109,9 +102,8 @@ public void startWithDsnString(String dsnString, final ReadableMap options, Prom
         sentryClient.addEventSendCallback(new EventSendCallback() {
             @Override
             public void onFailure(Event event, Exception exception) {
-                // This needs to be there, otherwise in case of no internet the users app will not
-                // crash since we do not propagate the error further. The system needs to be
-                // overhauled to remove this "hack".
+                // This needs to be there, otherwise in case of not internet the users app will not
+                // crash since we do not propagate the error further.
                 RNSentryEventEmitter.sendEvent(reactContext, RNSentryEventEmitter.SENTRY_EVENT_STORED, new WritableNativeMap());
                 RNSentryEventEmitter.sendEvent(reactContext, RNSentryEventEmitter.SENTRY_EVENT_SENT_SUCCESSFULLY, new WritableNativeMap());
             }

android/src/main/java/io/sentry/RNSentryPackage.java

@@ -5,28 +5,16 @@
 import java.util.Collections;
 import java.util.List;
 
-import com.facebook.react.ReactApplication;
 import com.facebook.react.ReactPackage;
 import com.facebook.react.bridge.NativeModule;
 import com.facebook.react.bridge.ReactApplicationContext;
 import com.facebook.react.uimanager.ViewManager;
 import com.facebook.react.bridge.JavaScriptModule;
 
 public class RNSentryPackage implements ReactPackage {
-
-    private final ReactApplication reactApplication;
-
-    public RNSentryPackage(ReactApplication reactApplication) {
-        this.reactApplication = reactApplication;
-    }
-
-    public ReactApplication getReactApplication() {
-        return reactApplication;
-    }
-
     @Override
     public List<NativeModule> createNativeModules(ReactApplicationContext reactContext) {
-        return Arrays.<NativeModule>asList(new RNSentryModule(reactContext, this.getReactApplication()), new RNSentryEventEmitter(reactContext));
+        return Arrays.<NativeModule>asList(new RNSentryModule(reactContext), new RNSentryEventEmitter(reactContext));
     }
 
     public List<Class<? extends JavaScriptModule>> createJSModules() {

package.json

@@ -37,7 +37,7 @@
       "postunlink": "node node_modules/@sentry/wizard/dist/bin.js -i reactNative -p ios android --uninstall"
     },
     "android": {
-      "packageInstance": "new RNSentryPackage(MainApplication.this)"
+      "packageInstance": "new RNSentryPackage()"
     },
     "ios": {
       "sharedLibraries": [