Merge pull request #27 from eliperkins/remove-superfluous-converts

HazAT · web-flow · commit 523f21341077 · 2017-03-31T10:45:58.000+02:00
Remove superfluous calls to RCTConvert
diff --git a/ios/RNSentry.m b/ios/RNSentry.m
@@ -72,7 +72,7 @@ + (NSRegularExpression *)frameRegex {
 
 RCT_EXPORT_METHOD(startWithDsnString:(NSString * _Nonnull)dsnString)
 {
-    [SentryClient setShared:[[SentryClient alloc] initWithDsnString:[RCTConvert NSString:dsnString]]];
+    [SentryClient setShared:[[SentryClient alloc] initWithDsnString:dsnString]];
     [[SentryClient shared] startCrashHandler];
 }
 
@@ -111,7 +111,7 @@ + (NSRegularExpression *)frameRegex {
 
 RCT_EXPORT_METHOD(captureMessage:(NSString * _Nonnull)message level:(int)level)
 {
-    [[SentryClient shared] captureMessage:[RCTConvert NSString:message] level:level];
+    [[SentryClient shared] captureMessage:message level:level];
 }
 
 RCT_EXPORT_METHOD(setLogLevel:(int)level)
@@ -121,12 +121,12 @@ + (NSRegularExpression *)frameRegex {
 
 RCT_EXPORT_METHOD(setExtras:(NSDictionary * _Nonnull)extras)
 {
-    [SentryClient shared].extra = [RCTConvert NSDictionary:extras];
+    [SentryClient shared].extra = extras;
 }
 
 RCT_EXPORT_METHOD(setTags:(NSDictionary * _Nonnull)tags)
 {
-    [SentryClient shared].tags = [self sanitizeDictionary:[RCTConvert NSDictionary:tags]];
+    [SentryClient shared].tags = [self sanitizeDictionary:tags];
 }
 
 RCT_EXPORT_METHOD(setUser:(NSDictionary * _Nonnull)user)

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ + (NSRegularExpression *)frameRegex {`
`72`	`72`
`73`	`73`	`RCT_EXPORT_METHOD(startWithDsnString:(NSString * _Nonnull)dsnString)`
`74`	`74`	`{`
`75`		`- [SentryClient setShared:[[SentryClient alloc] initWithDsnString:[RCTConvert NSString:dsnString]]];`
	`75`	`+ [SentryClient setShared:[[SentryClient alloc] initWithDsnString:dsnString]];`
`76`	`76`	`[[SentryClient shared] startCrashHandler];`
`77`	`77`	`}`
`78`	`78`
`@@ -111,7 +111,7 @@ + (NSRegularExpression *)frameRegex {`
`111`	`111`
`112`	`112`	`RCT_EXPORT_METHOD(captureMessage:(NSString * _Nonnull)message level:(int)level)`
`113`	`113`	`{`
`114`		`- [[SentryClient shared] captureMessage:[RCTConvert NSString:message] level:level];`
	`114`	`+ [[SentryClient shared] captureMessage:message level:level];`
`115`	`115`	`}`
`116`	`116`
`117`	`117`	`RCT_EXPORT_METHOD(setLogLevel:(int)level)`
`@@ -121,12 +121,12 @@ + (NSRegularExpression *)frameRegex {`
`121`	`121`
`122`	`122`	`RCT_EXPORT_METHOD(setExtras:(NSDictionary * _Nonnull)extras)`
`123`	`123`	`{`
`124`		`- [SentryClient shared].extra = [RCTConvert NSDictionary:extras];`
	`124`	`+ [SentryClient shared].extra = extras;`
`125`	`125`	`}`
`126`	`126`
`127`	`127`	`RCT_EXPORT_METHOD(setTags:(NSDictionary * _Nonnull)tags)`
`128`	`128`	`{`
`129`		`- [SentryClient shared].tags = [self sanitizeDictionary:[RCTConvert NSDictionary:tags]];`
	`129`	`+ [SentryClient shared].tags = [self sanitizeDictionary:tags];`
`130`	`130`	`}`
`131`	`131`
`132`	`132`	`RCT_EXPORT_METHOD(setUser:(NSDictionary * _Nonnull)user)`