Logs: enable iOS feature (#5190)

* enable ios logs:

* logs

* changelog

* Drop outdated clang-format from npm (#5191)

* enable logs on expo sample

* repro'

* patch clang-format and run it

* return flags

* return original sample code

* more rollback

* print clang version

* remove deprecated package, add clang-format setup

* try setup clang21

* other strategy to update clang/ more changes for version

* gh action name change

* Update .github/workflows/buildandtest.yml

---------

Co-authored-by: Lucas Zimerman <[email protected]>

Author: lucas-zimerman

.github/workflows/buildandtest.yml

@@ -51,6 +51,22 @@ jobs:
           cache-dependency-path: yarn.lock
       - name: Install Dependencies
         run: yarn install
+
+      # Default of ubuntu and apt packages are too old compared to macos packages.
+      # This is required for using a newer version of clang-format.
+      - name: Setup clang-format V20
+        run: |
+          sudo bash -c "$(wget -O - https://apt.llvm.org/llvm.sh)" 20
+          sudo apt-get install -y clang-20 clang-format-20 lld-20 lldb-20
+
+      - name: Set clang-format V20 as default
+        run: |
+          sudo update-alternatives --install /usr/bin/clang clang /usr/bin/clang-20 200
+          sudo update-alternatives --install /usr/bin/clang++ clang++ /usr/bin/clang++-20 200
+          sudo update-alternatives --install /usr/bin/clang-format clang-format /usr/bin/clang-format-20 200
+          clang --version
+          clang-format --version
+
       - name: Lint
         run: yarn lint
 

CHANGELOG.md

@@ -10,6 +10,7 @@
 
 ### Features
 
+- Enable logs on native side of iOS ([#5190](https://github.com/getsentry/sentry-react-native/pull/5190))
 - Add mobile replay attributes to logs  ([#5165](https://github.com/getsentry/sentry-react-native/pull/5165))
 
 ### Fixes

package.json

@@ -31,7 +31,6 @@
     "@expo/swiftlint": "^0.57.1",
     "@naturalcycles/ktlint": "^1.13.0",
     "@sentry/cli": "2.53.0",
-    "clang-format": "^1.8.0",
     "downlevel-dts": "^0.11.0",
     "google-java-format": "^1.4.0",
     "lerna": "^8.1.8",

packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentry+Test.h

@@ -1,7 +1,6 @@
 #import <RNSentry/RNSentry.h>
 
-@interface
-RNSentry (RNSentryInternal)
+@interface RNSentry (RNSentryInternal)
 
 + (SentryUser *_Nullable)userFrom:(NSDictionary *)userKeys
                     otherUserKeys:(NSDictionary *)userDataKeys;

packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryDependencyContainerTests.m

@@ -22,7 +22,7 @@ - (void)testRNSentryDependencyContainerInitializesFrameTracker
     OCMStub([(SentryDependencyContainer *)sentryDependencyContainerMock framesTracker])
         .andReturn(frameTrackerMock);
 
-    RNSentryEmitNewFrameEvent emitNewFrameEvent = ^(NSNumber *newFrameTimestampInSeconds) {};
+    RNSentryEmitNewFrameEvent emitNewFrameEvent = ^(NSNumber *newFrameTimestampInSeconds) { };
     [[RNSentryDependencyContainer sharedInstance]
         initializeFramesTrackerListenerWith:emitNewFrameEvent];
     XCTAssertNotNil([[RNSentryDependencyContainer sharedInstance] framesTrackerListener]);

packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryFramesTrackerListenerTests.m

@@ -46,7 +46,7 @@ - (void)testRNSentryFramesTrackerIsOneTimeListener
     OCMStub([(SentryDependencyContainer *)sentryDependencyContainerMock framesTracker])
         .andReturn(frameTrackerMock);
 
-    RNSentryEmitNewFrameEvent mockEventEmitter = ^(NSNumber *newFrameTimestampInSeconds) {};
+    RNSentryEmitNewFrameEvent mockEventEmitter = ^(NSNumber *newFrameTimestampInSeconds) { };
 
     RNSentryFramesTrackerListener *actualListener = [[RNSentryFramesTrackerListener alloc]
         initWithSentryFramesTracker:[[SentryDependencyContainer sharedInstance] framesTracker]
@@ -66,7 +66,7 @@ - (void)testRNSentryFramesTrackerAddsItselfAsListener
     OCMStub([(SentryDependencyContainer *)sentryDependencyContainerMock framesTracker])
         .andReturn(frameTrackerMock);
 
-    RNSentryEmitNewFrameEvent mockEventEmitter = ^(NSNumber *newFrameTimestampInSeconds) {};
+    RNSentryEmitNewFrameEvent mockEventEmitter = ^(NSNumber *newFrameTimestampInSeconds) { };
 
     RNSentryFramesTrackerListener *actualListener = [[RNSentryFramesTrackerListener alloc]
         initWithSentryFramesTracker:[[SentryDependencyContainer sharedInstance] framesTracker]

packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryOnDrawReporter+Test.h

@@ -1,8 +1,7 @@
 #import "RNSentryOnDrawReporter.h"
 #import <Foundation/Foundation.h>
 
-@interface
-RNSentryOnDrawReporterView (Testing)
+@interface RNSentryOnDrawReporterView (Testing)
 
 + (instancetype)createWithMockedListener;
 - (RNSentryEmitNewFrameEvent)createEmitNewFrameEvent;

packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryOnDrawReporter+Test.mm

@@ -28,8 +28,7 @@ - (void)framesTrackerHasNewFrame:(nonnull NSDate *)newFrameDate
 
 @end
 
-@implementation
-RNSentryOnDrawReporterView (Testing)
+@implementation RNSentryOnDrawReporterView (Testing)
 
 + (instancetype)createWithMockedListener
 {

packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryTests.h

@@ -3,8 +3,7 @@
 
 @class SentryOptions;
 
-@interface
-SentrySDKInternal (PrivateTests)
+@interface SentrySDKInternal (PrivateTests)
 
 + (nullable SentryOptions *)options;
 @end

packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryTests.m

@@ -316,6 +316,50 @@ - (void)testCreateOptionsWithDictionaryEnableUnhandledCPPExceptionsV2Default
         enableUnhandledCPPExceptions, @"enableUnhandledCPPExceptionsV2 should default to disabled");
 }
 
+- (void)testCreateOptionsWithDictionaryEnableLogsEnabled
+{
+    RNSentry *rnSentry = [[RNSentry alloc] init];
+    NSError *error = nil;
+
+    NSDictionary *_Nonnull mockedReactNativeDictionary = @{
+        @"dsn" : @"https://[email protected]/123456",
+        @"enableLogs" : @YES,
+    };
+    SentryOptions *actualOptions = [rnSentry createOptionsWithDictionary:mockedReactNativeDictionary
+                                                                   error:&error];
+
+    XCTAssertNotNil(actualOptions, @"Did not create sentry options");
+    XCTAssertNil(error, @"Should not pass no error");
+
+    id experimentalOptions = [actualOptions valueForKey:@"experimental"];
+    XCTAssertNotNil(experimentalOptions, @"Experimental options should not be nil");
+
+    BOOL enableLogs = [[experimentalOptions valueForKey:@"enableLogs"] boolValue];
+    XCTAssertTrue(enableLogs, @"enableLogs should be enabled");
+}
+
+- (void)testCreateOptionsWithDictionaryEnableLogsDisabled
+{
+    RNSentry *rnSentry = [[RNSentry alloc] init];
+    NSError *error = nil;
+
+    NSDictionary *_Nonnull mockedReactNativeDictionary = @{
+        @"dsn" : @"https://[email protected]/123456",
+        @"enableLogs" : @NO,
+    };
+    SentryOptions *actualOptions = [rnSentry createOptionsWithDictionary:mockedReactNativeDictionary
+                                                                   error:&error];
+
+    XCTAssertNotNil(actualOptions, @"Did not create sentry options");
+    XCTAssertNil(error, @"Should not pass no error");
+
+    id experimentalOptions = [actualOptions valueForKey:@"experimental"];
+    XCTAssertNotNil(experimentalOptions, @"Experimental options should not be nil");
+
+    BOOL enableLogs = [[experimentalOptions valueForKey:@"enableLogs"] boolValue];
+    XCTAssertFalse(enableLogs, @"enableLogs should be disabled");
+}
+
 - (void)testPassesErrorOnWrongDsn
 {
     RNSentry *rnSentry = [[RNSentry alloc] init];