Skip to content

Commit 8d97167

Browse files
misc: Remove deprecated Spotlight options (#4086)
1 parent 5a5c4b4 commit 8d97167

File tree

4 files changed

+3
-35
lines changed

4 files changed

+3
-35
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121

2222
### Changes
2323

24+
- Remove deprecated `enableSpotlight` and `spotlightSidecarUrl` ([#4086](https://github.com/getsentry/sentry-react-native/pull/4086))
2425
- `tracePropagationTargets` defaults to all targets on mobile and same origin on the web ([#4083](https://github.com/getsentry/sentry-react-native/pull/4083))
2526
- Move `_experiments.profilesSampleRate` to `profilesSampleRate` root options object [#3851](https://github.com/getsentry/sentry-react-native/pull/3851))
2627
- Add Android Logger when new frame event is not emitted ([#4081](https://github.com/getsentry/sentry-react-native/pull/4081))

packages/core/src/js/integrations/default.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,8 +127,8 @@ export function getDefaultIntegrations(options: ReactNativeClientOptions): Integ
127127
integrations.push(expoContextIntegration());
128128
}
129129

130-
if (options.spotlight || options.enableSpotlight) {
131-
const sidecarUrl = (typeof options.spotlight === 'string' && options.spotlight) || options.spotlightSidecarUrl;
130+
if (options.spotlight) {
131+
const sidecarUrl = typeof options.spotlight === 'string' ? options.spotlight : undefined;
132132
integrations.push(spotlightIntegration({ sidecarUrl }));
133133
}
134134

packages/core/src/js/options.ts

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -164,31 +164,6 @@ export interface BaseReactNativeOptions {
164164
*/
165165
enableCaptureFailedRequests?: boolean;
166166

167-
/**
168-
* This option will enable forwarding captured Sentry events to Spotlight.
169-
*
170-
* More details: https://spotlightjs.com/
171-
*
172-
* IMPORTANT: Only set this option to `true` while developing, not in production!
173-
*
174-
* @deprecated Use `spotlight` instead.
175-
*/
176-
enableSpotlight?: boolean;
177-
178-
/**
179-
* This option changes the default Spotlight Sidecar URL.
180-
*
181-
* By default, the SDK expects the Sidecar to be running
182-
* on the same host as React Native Metro Dev Server.
183-
*
184-
* More details: https://spotlightjs.com/
185-
*
186-
* @default "http://localhost:8969/stream"
187-
*
188-
* @deprecated Use `spotlight` instead.
189-
*/
190-
spotlightSidecarUrl?: string;
191-
192167
/**
193168
* If you use Spotlight by Sentry during development, use
194169
* this option to forward captured Sentry events to Spotlight.

packages/core/test/sdk.test.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -404,14 +404,6 @@ describe('Tests the SDK functionality', () => {
404404
expectNotIntegration('Spotlight');
405405
});
406406

407-
it('adds spotlight integration with enableSpotlight', () => {
408-
init({
409-
enableSpotlight: true,
410-
});
411-
412-
expectIntegration('Spotlight');
413-
});
414-
415407
it('no app start integration by default', () => {
416408
init({});
417409

0 commit comments

Comments
 (0)